Labels Milestones

New Issue

File extracted into wrong spot when mod uses no folder structure #2

Closed

opened 5 months ago by pandro · 0 comments

pandro commented 5 months ago

Owner

Issue

When a mod doesn't use any folder structure inside their zip-file and includes files besides the dll-file these additional files get exported into the base game folder.
This can be wrong.

How to reproduce

1. Download and add a mod without any folder structure inside the zip and mod files besides the dll (example mod)
2. Install the mod
3. Observer files being exported to the base game folder which is incorrect (for the example mod in question)

Expectation

If there is no folder structure at all but a dll file. Everything should be exported to BepInEx/plugins.

If there are folders but no BepInEx but others like plugins, config or customFolderName it should export them into BepInEx/

# Issue When a mod doesn't use any folder structure inside their zip-file and includes files besides the dll-file these additional files get exported into the base game folder. This can be wrong. ## How to reproduce 1. Download and add a mod without any folder structure inside the zip and mod files besides the dll ([example mod](https://thunderstore.io/c/lethal-company/p/ScottyFoxArt/CompanyIssuedProtogen/)) 2. Install the mod 3. Observer files being exported to the base game folder which is incorrect (for the example mod in question) ## Expectation If there is no folder structure at all but a dll file. Everything should be exported to `BepInEx/plugins`. If there are folders but no `BepInEx` but others like `plugins`, `config` or `customFolderName` it should export them into `BepInEx/`

pandro added the

bug

label 5 months ago

pandro self-assigned this 5 months ago

pandro referenced this issue from a commit 5 months ago

Fixed creating parent folders when extracting mods

pandro closed this issue 5 months ago

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

dev

v0.1

v0.3

Labels

Apply labels

Clear labels   

User Experience

Technically not a but but not working ideal or misleading for users   

bug

Something is not working   

duplicate

This issue or pull request already exists   

enhancement

New feature   

help wanted

Need some help   

invalid

Something is wrong   

question

More information is needed   

wontfix

This won't be fixed

No Label

User Experience

bug

duplicate

enhancement

help wanted

invalid

question

wontfix

Milestone

Set milestone

Clear milestone

No items

No Milestone

Assignees

Assign users

Clear assignees

No Assignees

pandro

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: pandro/LC_ModManager#2

Write Preview

Loading…

Cancel

Save

There is no content yet.