2664: Fix the bug reported by fastlorenzo r=mergify[bot] a=nextgens
## What type of PR?
bug-fix
## What does this PR do?
Fix the bug reported by fastlorenzo: when using proxy-auth, if the user doesn't exist you have to hit the URL twice.
### Related issue(s)
## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.
- [ ] In case of feature or enhancement: documentation updated accordingly
- [ ] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.
Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
2668: Start unbound with intended arguments r=mergify[bot] a=ScoreUnder
Unbound looked like it was meant to be started as if by `unbound -c /etc/unbound/unbound.conf`, but instead the string `-c /etc/unbound/unbound.conf` was set as argv[0] of the unbound command, meaning it is never parsed.
## What type of PR?
"Bugfix", but it works anyway without it -- it's just misleading to see a couple of arguments looking like they're being passed but actually just setting the display name of the process instead
## What does this PR do?
Calls execv with an argv list of 3 arguments (program name and intended 2 arguments) rather than just a program name. This appeared to be the intent of the original author.
### Related issue(s)
## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.
- [x] In case of feature or enhancement: documentation updated accordingly (n/a: bug)
- [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file. (n/a: minor)
Co-authored-by: score <seejay.11@gmail.com>
2667: Alpine 3.17.2 r=nextgens a=nextgens
## What type of PR?
bug-fix
## What does this PR do?
Alpine 3.17.2; This has a bunch of security fixes to openssl. Unclear whether and where we would be affected so I suggest we just patch.
### Related issue(s)
- closes#2669
## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.
- [ ] In case of feature or enhancement: documentation updated accordingly
- [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.
Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
Unbound looked like it was meant to be started as if by `unbound -c /etc/unbound/unbound.conf`, but instead the string `-c /etc/unbound/unbound.conf` was set as argv[0] of the unbound command, meaning it is never parsed.
2659: Doh. r=mergify[bot] a=nextgens
## What type of PR?
bug-fix
## What does this PR do?
Fix a bug introduced in #2646. Without this email delivery from RELAYNET is broken (admin throws a 400 that leads to a ``451 4.3.2 Internal server error``)
### Related issue(s)
- #2646
## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.
- [ ] In case of feature or enhancement: documentation updated accordingly
- [ ] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.
Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
2646: Smarter ratelimit r=mergify[bot] a=nextgens
## What type of PR?
enhancement
## What does this PR do?
Only account for **distinct** usernames in the IP rate-limiter.
This enables to have a much tighter default as a user with a misconfigured device will now only account for a single attempt.
The goal here is to make the rate-limiter more acceptable and to avoid people disabling it altogether.
### Related issue(s)
## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.
- [ ] In case of feature or enhancement: documentation updated accordingly
- [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.
Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
Co-authored-by: Alexander Graf <ghostwheel42@users.noreply.github.com>
2640: Add env variable to set sieve_vacation_to_header_ignore_envelope r=mergify[bot] a=nwinkelstraeter
When used with SRS the vacation plugin creates a reply with SRS in the To: header which does not look nice for the recipient. Setting sieve_vacation_to_header_ignore_envelope will use the headers from the original source message instead of potentially rewritten ones.
Without this option auto-replies are sent with a To header with SRS, e.g `SRS0=uetG=43=sender.com=user@autoresponder.com`
With this option they are sent with just `user@sender.com`
This option is for whatever reason not part of the [pigeonhole docs](https://doc.dovecot.org/configuration_manual/sieve/extensions/vacation/) but it is documented here: 34431d7a67/NEWS (L338)
## What type of PR?
enhancement
## What does this PR do?
This PR adds an environment variable to the set the `sieve_vacation_to_header_ignore_envelope` configuration
## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.
- [x] In case of feature or enhancement: documentation updated accordingly
Co-authored-by: Nico Winkelsträter <nico.winkelstraeter@initos.com>
Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
This is done by setting sieve_vacation_to_header_ignore_envelope to yes
The envelope is rewritten by recipent_canonical_maps to reverse SRS after the plugin checks it
so we need the plugin to ignore it at this point.
2656: Zero quota is unlimited r=mergify[bot] a=ghostwheel42
## What type of PR?
bug-fix
## What does this PR do?
Show a quota of zero as unlimkted in roundcube webmail.
### Related issue(s)
see [#2418](https://github.com/Mailu/Mailu/issues/2418#issuecomment-1418714921)
Co-authored-by: Alexander Graf <ghostwheel42@users.noreply.github.com>
2651: Allow + in localpart of addresses to forward to r=mergify[bot] a=nextgens
## What type of PR?
bug-fix
## What does this PR do?
Allow + in localpart of addresses to forward to
### Related issue(s)
- close#1236
## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.
- [ ] In case of feature or enhancement: documentation updated accordingly
- [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.
Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
2650: Tell roundcube that sieve scripts should be utf8 encoded r=mergify[bot] a=nextgens
## What type of PR?
bug-fix
## What does this PR do?
Tell roundcube that sieve scripts should be utf8 encoded.
### Related issue(s)
- Close#2258
## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.
- [ ] In case of feature or enhancement: documentation updated accordingly
- [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.
Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
2643: Fix nginx config r=mergify[bot] a=Diman0
Forgot to adapt some IF statements. All config is normalized now for front.
So true/false now matches the boolean value True/False. Instead if {% IF X == 'true' %} we should now use {% IF X %}
## What type of PR?
bug-fix
## What does this PR do?
Fixes a bug in the nginx config. This bug prevents the /admin endpoint from being exposed.
### Related issue(s)
## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.
- [ n/a] In case of feature or enhancement: documentation updated accordingly
- [ n/a] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.
Co-authored-by: Dimitri Huisman <diman@huisman.xyz>
2638: further finishing touches for restful api r=mergify[bot] a=Diman0
- Fix setup utility setting correct value to env var API. It now also sets `false` when the API is disabled in the setup utility.
- Fix IF statement for enabling API in nginx.conf. Setting a different value than `API=true` in mailu.env now disabled the API endpoint in nginx.
- Use safer command for regenerating example API token. It uses crypto.getRandomValues() (as suggested by nextgens) which should be more random than the previously used method.
## What type of PR?
bug-fix
## What does this PR do?
### Related issue(s)
## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.
- [ ] In case of feature or enhancement: documentation updated accordingly
- [ ] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.
Co-authored-by: Dimitri Huisman <diman@huisman.xyz>
2641: Remove webmail cookies on logout. r=mergify[bot] a=ghostwheel42
## What type of PR?
bug-fix
## What does this PR do?
sometimes at least roundcube webmail is confused when changing users.
this deletes the webmail session cookies to avoid the confusion.
Co-authored-by: Alexander Graf <ghostwheel42@users.noreply.github.com>
2639: Update demo docs with new capabilities r=mergify[bot] a=Diman0
## What type of PR?
documentation
## What does this PR do?
Update the demo documentation that the demo server now also exposes the new RESTful API.
### Related issue(s)
n/a
## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.
- [ n/a] In case of feature or enhancement: documentation updated accordingly
- [ /na] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.
Co-authored-by: Dimitri Huisman <diman@huisman.xyz>
2632: Interface cosmetics r=mergify[bot] a=ghostwheel42
## What type of PR?
enhancement, bug-fix
## What does this PR do?
- add default sort order to all tables
- repair sliders
- add quota in list
- improve mailu logo in roundcube webmail when using responsive skin
- show version in the footer (after login)
### Related issue(s)
- closes#2570
Co-authored-by: Alexander Graf <ghostwheel42@users.noreply.github.com>
S474N