2200: Switch to ISRG_Root_X1 in front nginx r=mergify[bot] a=packet23
## What type of PR?
bug-fix
## What does this PR do?
### Related issue(s)
Resolves an nginx startup issue when letsencrypt or mail-letsencrypt is enabled.
closes#2199
## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.
- [X] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.
Co-authored-by: Sebastian Klemke <3669903+packet23@users.noreply.github.com>
Co-authored-by: Florent Daigniere <nextgens@users.noreply.github.com>
2193: Update php.ini r=mergify[bot] a=audioscavenger
matching rainloop php to roundcube's: timezone is a parameter in mailu.env
## What type of PR?
bug-fix
## What does this PR do?
### Related issue(s)
- none
Co-authored-by: Eric <dev@derewonko.com>
2190: Tag for release is correctly tagged to branch x.y. r=mergify[bot] a=Diman0
## What type of PR?
Bug-fix
## What does this PR do?
CI/CD had two issues which are addressed by this PR.
- calculating new x.y.z failed for x.y.10+
- tag was not created for branch x.y, but master. This resulted in the release pointing to the wrong commit.
backport is required to make this workflow available for 1.9.
### Related issue(s)
- closes#2124
## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.
- [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.
Co-authored-by: Dimitri Huisman <diman@huisman.xyz>
2182: disabled rsyslogd pidfile r=mergify[bot] a=packet23
## What type of PR?
bug-fix
## What does this PR do?
The change disables the pidfile for rsyslog in the mailu/postfix container image. This fixes an issue where rsyslogd exits after `docker-compose up -d` / `docker-compose stop` / `docker-compose start` with
```
smtp_1 | rsyslogd: pidfile '/var/run/rsyslogd.pid' and pid 8 already exist.
smtp_1 | rsyslogd: run failed with error -3000 (see rsyslog.h or try https://www.rsyslog.com/e/3000 to learn what that number means)
```
due to a conflict with already existing pidfile.
### Related issue(s)
## Prerequisites
Co-authored-by: Sebastian Klemke <3669903+packet23@users.noreply.github.com>
2161: fix typo r=mergify[bot] a=erikvimz
## What type of PR?
documentation
## What does this PR do?
fixes a typo
Co-authored-by: Erik Kralj <erik@kralj.dev>
2179: Fix resolver r=mergify[bot] a=nextgens
## What type of PR?
bug-fix
## What does this PR do?
Switch to the new API to solve a k8s specific problem
### Related issue(s)
- #2177
Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
Co-authored-by: Billy Chan <shing@PC1>
2177: Update start.py to fix the resolver test r=mergify[bot] a=shing6326
Use method resolve instead of query to fix the resolver test
## What type of PR?
bug-fix
## What does this PR do?
### Related issue(s)
- Mention an issue like: #001
- Auto close an issue like: closes#001
## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.
- [ ] In case of feature or enhancement: documentation updated accordingly
- [ ] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.
Co-authored-by: shing6326 <42719827+shing6326@users.noreply.github.com>
Co-authored-by: Billy Chan <shing@PC1>
2171: fixed plugin path r=mergify[bot] a=ghostwheel42
## What type of PR?
bug-fix
## What does this PR do?
use correct plugin path to verify plugin list
### Related issue(s)
closes: #2168
## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.
- [ ] In case of feature or enhancement: documentation updated accordingly
- [ ] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.
Co-authored-by: Alexander Graf <ghostwheel42@users.noreply.github.com>
2144: Enable unbound by default, warn if the DNS resolver doesn't work r=mergify[bot] a=nextgens
## What type of PR?
bug-fix
## What does this PR do?
Enable unbound by default, warn if the DNS resolver doesn't work
### Related issue(s)
- close#2135
## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.
- [ ] In case of feature or enhancement: documentation updated accordingly
- [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.
Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
Co-authored-by: Florent Daigniere <nextgens@users.noreply.github.com>
2158: supply missing fields argument r=mergify[bot] a=ghostwheel42
## What type of PR?
bug-fix
## What does this PR do?
adds missing argument "fields" to login form.
### Related issue(s)
- closes#2155
## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.
- [ ] In case of feature or enhancement: documentation updated accordingly
- [ ] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.
Co-authored-by: Alexander Graf <ghostwheel42@users.noreply.github.com>
2150: fix 2145: exceptions may be thrown when login is invalid or rate-limits exceeded r=mergify[bot] a=nextgens
## What type of PR?
bug-fix
## What does this PR do?
Exceptions may be thrown when login is invalid or rate-limits exceeded for those running very recent builds of 1.9
For some reason I haven't caught it while testing #2130... that's when it was introduced.
### Related issue(s)
- close#2145
- close#2146
- #2130
Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
2149: fix 2147: MESSAGE_SIZE_LIMIT wasn't working r=mergify[bot] a=nextgens
## What type of PR?
bug-fix
## What does this PR do?
Set client_max_body_size in the server's scope.
I haven't tested it but it makes sense regardless.
### Related issue(s)
- closes#2147
Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
2141: update roundcube to 1.5.2 (security fix) r=mergify[bot] a=willofr
New roundcube release (1.5.2) where a XSS is addressed: https://roundcube.net/news/2021/12/30/update-1.5.2-released
## What type of PR?
security fix
## What does this PR do?
Update roundcube from 1.5.1 to 1.5.2
This update fixes an XSS: https://roundcube.net/news/2021/12/30/update-1.5.2-released
### Related issue(s)
None
## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.
- [x] In case of feature or enhancement: documentation updated accordingly
- [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.
Co-authored-by: willofr <willofr@users.noreply.github.com>
2140: Fix 2138: Pin DANE with the full cert r=mergify[bot] a=nextgens
## What type of PR?
bug-fix
## What does this PR do?
Pin the intermediates rather than the root for DANE. If you have setup TLSA records following previous suggestion from Mailu please update them.
This hasn't been tested.
The four options here are:
- stop suggesting DANE records
- send the root CA (4096 bits extra per handshake!)
- pin the intermediates : the downside is that these are only valid for 3y, see https://letsencrypt.org/certificates/ and we should pin 4: R3,R4,E1,E2
- setup a 'full' DANE record in DNS (this is what this PR does)
The high priority is warranted by the fact that some SMTP servers may not trust root CAs and may enforce DANE strictly (it may break things).
### Related issue(s)
- close#2138
## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.
- [ ] In case of feature or enhancement: documentation updated accordingly
- [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.
Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
Co-authored-by: Florent Daigniere <nextgens@users.noreply.github.com>
Mario Jauvin