You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
d2ff6769cc
1669: Fix extract_host_port port separation r=mergify[bot] a=cbachert Regex quantifier should be lazy to make port separation work. ## What type of PR? bug-fix ## What does this PR do? The "extract_host_port" function in admin/mailu/internal/nginx.py and optional/fetchmail/fetchmail.py is not actually separating host and port due to the `(.*)` part of the regex being too generous. Lazy quantifier `(.*?)` allows the other capturing groups to match. ### Related issue(s) - No issue raised for this ## Prerequistes - [x] Documentation updated accordingly: N/A, bug-fix - [x] Add [changelog] entry file: Added towncrier newsfragment with second commit 1672: mark radio buttons in setup utility as required r=mergify[bot] a=lub ## What type of PR? bug-fix ## What does this PR do? mark radio buttons in setup utility as required Otherwise it's possible to submit the form without selecting e.g. any flavor, which would need additional handling on the server side. ### Related issue(s) ## Prerequistes Before we can consider review and merge, please make sure the following list is done and checked. If an entry in not applicable, you can check it or remove it from the list. - [ ] In case of feature or enhancement: documentation updated accordingly - [ ] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/guide.html#changelog) entry file. Co-authored-by: cbachert <cbachert@users.noreply.github.com> Co-authored-by: lub <git@lubiland.de> |
4 years ago | |
|---|---|---|
| .. | ||
| 1669.bugfix | 4 years ago | |