lub
/
mailu
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity
You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
main
dynamic-resolution
master
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '8c8c1b2015'
${ noResults }
mailu/core/admin
History
bors[bot] 8c8c1b2015
Merge #1997 
1997: Prevent traceback when using non-email in login r=mergify[bot] a=ghostwheel42

There's a traceback when the username used to log via SMTPAUTH
in is not an email address:

=== before ===
```
[...] ERROR in app: Exception on /internal/auth/email [GET]
Traceback (most recent call last):
  File "/usr/lib/python3.9/site-packages/sqlalchemy/engine/base.py", line 1179, in _execute_context
    context = constructor(dialect, self, conn, *args)
  File "/usr/lib/python3.9/site-packages/sqlalchemy/engine/default.py", line 719, in _init_compiled
    param.append(processors[key](compiled_params[key]))
  File "/usr/lib/python3.9/site-packages/sqlalchemy/sql/type_api.py", line 1201, in process
    return process_param(value, dialect)
  File "/app/mailu/models.py", line 60, in process_bind_param
    localpart, domain_name = value.lower().rsplit('`@',` 1)
ValueError: not enough values to unpack (expected 2, got 1)
[...]
[parameters: [{'%(140657157923216 param)s': 'foobar'}]]
```

=== after ===
```
[...] WARNING in nginx: Invalid user 'foobar': (builtins.ValueError) invalid email address (no "`@")`
```

## What type of PR?

enhancement

## What does this PR do?

replace traceback (ERROR) with error message (WARNING)

### Related issue(s)

## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.

- [ ] In case of feature or enhancement: documentation updated accordingly
- [ ] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.


Co-authored-by: Alexander Graf <ghostwheel42@users.noreply.github.com>
 		3 years ago
..
assets moved javascript to app.js 3 years ago
mailu Merge #1997 3 years ago
migrations Fix typo in migration file 5 years ago
.gitignore Move all directories per theme 7 years ago
Dockerfile Merge remote-tracking branch 'upstream/master' into adminlte3_fixes 3 years ago
README.md Move all directories per theme 7 years ago
audit.py Move all directories per theme 7 years ago
babel.cfg Move all directories per theme 7 years ago
messages.pot Remove services status localization 6 years ago
package.json AdminLTE3 optimizations & compression and caching 3 years ago
requirements-prod.txt AdminLTE3 optimizations & compression and caching 3 years ago
requirements.txt Merge remote-tracking branch 'upstream/master' into kvsession 3 years ago
start.py Use threads in gunicorn rather than processes 3 years ago
webpack.config.js AdminLTE3 optimizations & compression and caching 3 years ago

README.md

Mailu Admin container

This is the web-based administrative interface for the Mailu containerized mail server.

Resources