2265: Prevent an exception from being thrown if the username isn't an email address r=mergify[bot] a=nextgens
## What type of PR?
enhancement
## What does this PR do?
Mailu expects users to identify using an email address; some brute-force script don't send just an username and this leads to an exception... that makes the error message and return code vary.
This PR prevents the exceptions from being thrown in the first place
```
WARNING in nginx: Invalid user 'xxxx': (builtins.ValueError) invalid email address (no "`@")"`
```
### Related issue(s)
- closes#2261
- closes#1750
Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
Co-authored-by: Florent Daigniere <nextgens@users.noreply.github.com>
2254: Send ISRG_X1 on port 25, make DANE pin that r=mergify[bot] a=nextgens
## What type of PR?
bug-fix
## What does this PR do?
Ensure we send ISRG_X1 in the handshake on port 25 (non-interactive, size doesn't really matter).
Update the DANE pin to reflect the change.
I am not sure whether we will need to add --preferred-chain= in the future; This may be the case when letsencrypt decides to use X2/the ECDSA chain
This needs to be tested on a letsencrypt account that isn't mine (I'm opted in for the alternate cert chains)
### Related issue(s)
- closes#2138
## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.
There's already a towncrier news for it
Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
2253: Workaround the infamous coredns feature r=mergify[bot] a=nextgens
## What type of PR?
bug-fix
## What does this PR do?
Ensure that we set the ``DO`` flag on our queries to work around https://github.com/coredns/coredns/issues/5189
Add a FAQ entry to point users in the right direction in other cases (dnsmasq), discourage users from running Mailu without unbound
### Related issue(s)
- closes#2243
- closes#2239
- #2164
- #2163
- #2162
- #2135
- #1988
## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.
- [x] In case of feature or enhancement: documentation updated accordingly
- [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.
Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
Co-authored-by: Dimitri Huisman <diman@huisman.xyz>
2251: Fix broken setup. Not all dependencies were pinned. As usual a depend… r=mergify[bot] a=Diman0
…ency had a breaking update.
## What type of PR?
bug-fix
## What does this PR do?
The dependencies pulled in by the python packages required for setup were not pinned. Unfortunately one of the dependencies had a breaking update. This PR also pins all dependencies to the last working version.
### Related issue(s)
- closes#2249
## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.
- [x] In case of feature or enhancement: documentation updated accordingly
- [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.
Co-authored-by: Dimitri Huisman <diman@huisman.xyz>
2185: Update reverse.rst r=mergify[bot] a=audioscavenger
updated the external proxy location pattern and added a note: do not add a ``/`` at the end
## What type of PR?
documentation
## What does this PR do?
### Related issue(s)
- did not bother to create an issue
## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.
- [ ] i would like to add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file but i don't know how
Co-authored-by: Eric <dev@derewonko.com>
2195: roundcube: Add /overrides directory in include r=mergify[bot] a=mnival
Added the /overrides directory in the roundcube config.inc.php file
## What type of PR?
bug-fix
## What does this PR do?
### Related issue(s)
none
Co-authored-by: mnival <1595998+mnival@users.noreply.github.com>
Co-authored-by: Dimitri Huisman <diman@huisman.xyz>
2207: Update webmail container configuration to support MESSAGE_SIZE_LIMIT r=mergify[bot] a=marioja
## What type of PR?
bug-fix
## What does this PR do?
### Related issue(s)
- Auto close an issue like: closes#2186
## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.
- [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.
Co-authored-by: Mario Jauvin <marioja@users.noreply.github.com>
2216: Add iptables+ipset as additional FAQ entry for fail2ban r=mergify[bot] a=tkaefer
## What type of PR?
(Feature, enhancement, bug-fix, documentation)
## What does this PR do?
### Related issue(s)
closes#2214
## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.
- [x] In case of feature or enhancement: documentation updated accordingly
- [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.
Co-authored-by: Tobias Käfer <tobias@tkaefer.de>
2196: roundcube-carddav : Use des_key for pwstore_scheme r=nextgens a=mnival
roundcube-carddav: Configuring pwstore_scheme in carddav plugin with des_key because Mailu is incompatible with encrypted
https://github.com/mstilkerich/rcmcarddav/blob/master/doc/ADMIN-SETTINGS.md#password-storing-scheme
## What type of PR?
bug-fix
## What does this PR do?
### Related issue(s)
- closes#2230
Co-authored-by: mnival <1595998+mnival@users.noreply.github.com>
2234: fix#2220 r=mergify[bot] a=nextgens
## What type of PR?
bug-fix
## What does this PR do?
Fix the CI. I don't understand webpack well enough but that does the trick.
### Related issue(s)
- close#2220
Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
2209: Change URL dashboard in DKIM/SPF & DMARC Entries r=mergify[bot] a=0pc0deFR
## What type of PR?
documentation
## What does this PR do?
Example URL correction in documentation of DKIM/SPF & DMARC Entries
### Related issue(s)
- Mention an issue like: #2123
- Auto close an issue like: closes#2123
## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.
- [ X] In case of feature or enhancement: documentation updated accordingly
- [ ] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.
Co-authored-by: Kevin Falcoz <0pc0defr@gmail.com>
2211: Ensure we use IMAP IDLE like it's supposed to work r=mergify[bot] a=nextgens
## What type of PR?
enhancement
## What does this PR do?
Increase IMAP IDLE time from 2min to 29mins: this should massively help reduce network traffic & increase battery life of clients
See https://peterkieser.com/2011/03/25/androids-k-9-mail-battery-life-and-dovecots-push-imap/
## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.
- [ ] In case of feature or enhancement: documentation updated accordingly
- [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.
Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
Co-authored-by: Florent Daigniere <nextgens@users.noreply.github.com>
2206: Patch function "Display Name" into admin page r=mergify[bot] a=0pc0deFR
## What type of PR?
bug-fix
## What does this PR do?
This PR is bug-fix for #2100
### Related issue(s)
- Mention an issue like: #2100
- Auto close an issue like: closes#2100
Co-authored-by: Kevin Falcoz <0pc0defr@gmail.com>
Co-authored-by: Kevin Falcoz <0pc0deFR@gmail.com>
bors[bot]