Commit Graph

470 Commits (a150315c1dabfc36682aba7a0e455d87c45d7d8e)

Author SHA1 Message Date
mergify[bot] 278bcfb13a
Merge pull request from Nebukadneza/fix_delimiter_alias
Deliver mails to alias-stripped-of-delimeter, even if catchall exists
Dario Ernst 276dc3ffda Reverse the resolution order of user and alias
Since it’s common for wildcard~ish systems to prefer concrete objects over
wildcards, and aliases can be broad-wildcards (think catchall, %@xxx.tld), it
may be more intuitive for users that user-names rank higher than aliases. This
makes it impossible for user-names to be unreachable, since they can be
completely overridden by a catchall otherwise.

This changes default behavior, and is not configurable.

closes 
Tim Möhlmann 8541ae2c46
Fix migration order after merge
mergify[bot] 99cd1d714b
Merge pull request from hoellen/fix-domain-negative-values-1
don't allow negative values on domain creation/edit
Tim Möhlmann 2567646f47
Merge branch 'master' into fix-domain-negative-values-1
Ionut Filip 50343f354e Merge remote-tracking branch 'upstream/master' into feat-psql-support
Dario Ernst b8d1beed29 Simplify alias-wildcard detection to not consider actual % anymore
Dario Ernst 10d2601963 Unsimplify alias precedence handling
As discussed with hoellen on matrix, since postfix indeed supports including
the recipient delimiter character in a verbatim alias, we should support so too
— and handle its precedence correctly. The clearer and simpler formulation of
the precedence-clauses are credit to @hoellen. Thanks!
mergify[bot] b4822ad43e
Merge pull request from HorayNarea/fix-remove-fts
remove (broken) FTS
mergify[bot] 161394a774
Merge pull request from hoellen/fix-fetch-passwordfield-1
fix edit of fetched acc without changing password
Thomas Sänger 492f3867d8
remove (broken) FTS
Dario Ernst ac64a75743 Simplify alias precedence handling; Remove bogus changelog
mergify[bot] 520ebbb97d
Merge pull request from hoellen/move-spam-1
Mark messages as seen when reporting them as spam
hoellen 7247b4b10c
Merge branch 'master' into fix-password-on-user-edit
hoellen b65d70cf1e mark spam as seen
hoellen a59d5dad23 fix edit of fetched acc without changing password
hoellen f08491dc46 fix forced password on user edit
Ionut Filip 2b0a2d561b Fix connection to mysql db
Dario Ernst 291f8a457b Deliver mails to alias-stripped-of-delimeter, even if catchall exists
This fixes delivery to an alias minus recipient delimiter in cases where a
wildcard alias would also match. For example,
* foo@xxx.tld
* %@xxx.tld
Sending to foo+spam@xxx.tld would get eaten by the catchall before this fix.
Now, the order of alias resolution is made clearer.

closes 
hoellen 732b5fe161 change password field type in fetch creation/edit and add validators.
mergify[bot] 4204facd85
Merge pull request from usrpro/feat-logging
Implement some degree of logging
Tim Möhlmann 049ca9941f
Cleanup syntax and fix typo
Tim Möhlmann 0ac3cf9617
Don't recursivly chown on mailboxes.
This fixes .
Recursion is not needed, as the permissions will only need to be set on the first invocation.
Tim Möhlmann 71cda7983e
Merge branch 'master' into feat-logging
Tim Möhlmann 7d01bb2a4d
LOG_LEVEL docs and changelog entry
Tim Möhlmann b04a9d1c28
Implement debug logging for template rendering
Tim Möhlmann b9313488dd
Add logging for tenacity.retry
In the process we found that the previous way of tenacity syntax caused it not to honor any args.
In this commit we've refactored to use the @decorator syntax, in which tenacity seems to behave better.
mergify[bot] 3b5f3af207
Merge pull request from Nebukadneza/fix_recipient_delimiter
Attempt stripping recipient delimiter from localpart
Ionut Filip 9077bf7313 Merge remote-tracking branch 'upstream/master' into feat-psql-support
Tim Möhlmann 5636e7f5a7
Remove to avoid matching webroot
Ionut Filip 953aa04354 Added postgresql-libs to admin
Tim Möhlmann 561e2fda67
Merge remote-tracking branch 'upstream/master' into fix-favicon
hoellen 501ecf13c1 add migration script
Tim Möhlmann a358b5305f
Merge pull request from Mailu/upgrade-pyyaml
Upgrade PyYAML
Tim Möhlmann 4f93e09028
Implement favicon package
Credit to:
- https://stackoverflow.com/a/19590415/1816774
- https://realfavicongenerator.net/
Tim Möhlmann 284d54190a
Upgrade PyYAML to 4.2b4
hoellen dda64fe91e allow to disable aliases or users for domains and don't allow negativ values on domain creation/edit
hoellen 8fe1e788b3 add missing route fixes
Tim Möhlmann 3c7bf58211
Upgrade PyYAML
CVE-2017-18342
Vulnerable versions: < 4.2b1
Patched version: 4.2b1
In PyYAML before 4.1, the yaml.load() API could execute arbitrary code. In other words, yaml.safe_load is not used.
hoellen d5d4d6c337 harden email address validation and fix routes with user_email
Ionut Filip 01ec6e7bf3 Removed undefined function
mergify[bot] d483ef3c2a
Merge pull request from hoellen/admin-broken-links-1
fix broken webmail and logo url in admin
Tim Möhlmann 74fe177297
Merge pull request from TheLegend875/feat-displayed-name
Feature: send auto reply with displayed name
hoellen f617e82c06 fix broken webmail and logo url in admin
Tim Möhlmann 4068c5b751
Versioning for mysqlclient and psycopg2
Tim Möhlmann b2823c23b8
Merge remote-tracking branch 'upstream/master' into feat-psql-support
Tim Möhlmann 9eaeb80a27
Finalize merge with kaiyou/feat-multiple-db
TheLegend875 999d2a9557 changed default.sieve to send displayed name
TheLegend875 2954d84790 added necessary ui elements
TheLegend875 56f4d4c894 fixed auto-forward
TheLegend875 5bdbbf60d7 fixed display of username when not logged in
Dario Ernst c2d45a47fe Attempt stripping recipient delimiter from localpart
Since postfix now asks us for the complete email over podop, which
includes the recipient-delimiter-and-what-follows not stripped, we need
to attempt to find both the verbatim localpart, as well as the localpart
stripped of the delimited part ….

Fixes 
Tim Möhlmann 19df86f13f
Merge pull request from usrpro/fix-alias-bug
Added regex validation for alias username
Tim Möhlmann 3a5b763018
Option to disable full text search (lucene)
This is a workaround for the bug in issue 
mergify-bot 983c388150 Merge branch 'master' into 'fix-localpart-chars'
mergify-bot 6cfb74e96c Merge branch 'master' into 'fix-localpart-chars'
Tim Möhlmann af086bbdbe
Include DKIM in VOLUME
hoellen c041a9d45c allow all characters for username in dovecot
Tim Möhlmann 24828615cf
Webmail on root, fixes
Ionut Filip 8fc2846924 Added regex validation for alias username
Tim Möhlmann 3c4ee1b31e
Merge pull request from kaiyou/master
Fixes  regarding application context
ofthesun9 97b3a85090
Merge pull request from hoellen/fix-alias-match-behaviour
fix alias match behaviour
mergify-bot 09a50b6cfc Merge branch 'master' into 'master'
kaiyou 4060ac2223 Remove some forgotten debugging
kaiyou 087841d5b7 Fix the way we handle the application context
The init script was pushing an application context, which maked
flask.g global and persisted across requests. This was evaluated
to have a minimal security impact.

This explains/fixes : flask_wtf caches the csrf token in the
application context to have a single token per request, and only
sets the session attribute after the first generation.
kaiyou b5f51b0e2e Update python dependencies
kaiyou 8707b0fcd7 Use a dictionary of db connection string templates
kaiyou 19f18e2240 Lowercase relays as well as other tables
kaiyou 7e388e472a Handle relay name as an Idna domain
kaiyou 871aa14c9a Lowercase every domain name and email
kaiyou 3df9b3962d Add default columns to the configuration table
kaiyou b88f61f183 Name all constraints when creating them
Prefious commit set the constraint names for existing databases.
New databases can now have named constraints from the ground up.
kaiyou b8282b1d46 Support named constraints for multiple backends
Supporting multiple backends requires that specific sqlite
collations are not used, thus lowercase is applied to all non
case-sensitive columns. However, lowercasing the database requires
temporary disabling foreign key constraints, which is not possible
on SQLite and requires we specify the constraint names.

This migration specific to sqlite and postgresql drops every
constraint, whether it is named or not, and recreates all of them
with known names so we can later disable them.
kaiyou e022513a94 Fix support for postgres and mysql
kaiyou a881a1a839 Revert "Make current migrations work with postgresql"
This reverts commit 9b9f3731f6.
kaiyou 76925e82f3 Revert "Implement CIText as NOCASE alternative in postgresql"
This reverts commit 0f3c1b9d15.
kaiyou f52ae5535c Revert "Created function for returning email type"
This reverts commit 436055f02c.
kaiyou f6520eace6 Merge branch 'feat-psql-support' of https://github.com/usrpro/Mailu into usrpro-feat-psql-support
hoellen 8fe9e695f3 prefer non-wildcard aliases over wildcard aliases
Tim Möhlmann c7dcfee882
Merge pull request from pgeorgi/extend-nginx
nginx: Allow extending config with overrides
hoellen 79768c09f6 fix alias matching behaviour
Tim Möhlmann 6ca8ed437d
Merge pull request from Nebukadneza/add_front_certificate_reload
Add certificate watcher for external certs to reload nginx
Dario Ernst 1aa97c9914 Add certificate watcher for external certs to reload nginx
In case of TLS_FLAVOR=[mail,cert], the user supplies their own certificates.
However, since nginx is not aware of changes to these files, it cannot
reload itself e.g. when the certs get renewed.

To solve this, let’s add a small daemon in the place of
`letsencrypt.py`, which uses a flexible file-watching framework and
reloads nginx in the case the certificates change ….
Tim Möhlmann c00910ca4b
Merge remote-tracking branch 'upstream/master' into extend-nginx
Tim Möhlmann 97d338e68a
Rectify 'endif' placement
Tim Möhlmann 425cdd5e77
Fix syntax errors
Tim Möhlmann 20f1faf6d0
Send 404 when nothing server at '/'
Prevents Nginx welcome screen
Tim Möhlmann 2de4995fec
Don't redirect when webmail is served on '/'
Tim Möhlmann f0906073e3
Merge remote-tracking branch 'upstream/master' into feat-subnet2
mergify[bot] a634c7b72d
Merge pull request from usrpro/fix-outlook2019-smtp
Add login method to smtp_auth under ssl
Tim Möhlmann 8172f3eab8
Move the Mailu Docker network to a fixed subnet.
This will make network configuration and host based authentication
more robust, across different deployment platforms.
The options `RELAYNETS` and`POD_ADDRESS_RANGE` are kept for compatibility.
However, their usage have become optional.
kaiyou b6aaf57be1 Merge branch 'refactor-config' of github.com:kaiyou/mailu into refactor-config
kaiyou d0f07984b0 Merge remote-tracking branch 'upstream/master' into refactor-config
Tim Möhlmann 9dd447e23b
Add login method to smtp_auth under ssl
Fixes 
Patrick Georgi eac4d553a9 nginx: Allow extending config with overrides
To facilitate this, the default redirect at / can be disabled, even if
the default remains at redirecting to the webmailer.

The extensions are within the host scope and are read from
$ROOT/overrides/nginx/*.conf.
mergify[bot] 2d4bac03ad
Merge pull request from usrpro/clean-healthcheck-logs
Admin: Prevent redirects during health checking
mergify[bot] a382f74680
Merge pull request from usrpro/fix-recaptcha
Fix recaptcha
mergify[bot] 37027cfce7
Merge pull request from kaiyou/fix-sender-checks
Improve sender checks
Tim Möhlmann d18cf7cb25
Prevent redirects during health checking
Tim Möhlmann c9df311a0d
Set forward_destination to an empty list
The value of `None` resulted in an error, since a list was expected.