Commit Graph

1530 Commits (3e45a791cf39a57ed290a02ae94dc1fc20ce7057)

Author SHA1 Message Date
Florent Daigniere 505bb79a78 Don't set the secure Cookie flag if TLS_FLAVOR=notls
Florent Daigniere 08a9ab9a56 Improve fetchmail
Florent Daigniere 455180043d doh
bors[bot] 8a90f83bd0
Merge
2514: Update deps r=mergify[bot] a=ghostwheel42

## What type of PR?

update python dependencies

## What does this PR do?

Update python deps in base image


Co-authored-by: Alexander Graf <ghostwheel42@users.noreply.github.com>
Florent Daigniere f11c451403 Restrict it to arch where there is a package
Florent Daigniere 97df65e9ef Switch to GrapheneOS's hardened_malloc
This was suggested during the dev meeting of the 18/09/22.

It may break things and it may make things unbearably slow
bors[bot] 745c211c4a
Merge
2523: fix JS error r=mergify[bot] a=nextgens

## What type of PR?

bug-fix

## What does this PR do?

It fixes a bug whereby one may have to click twice on the submit button depending on timing.

e.trigger() will error out on most browsers.

Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
bors[bot] 0839490beb
Merge
2479: Rework the anti-spoofing rule r=mergify[bot] a=nextgens

## What type of PR?

Feature

## What does this PR do?

We shouldn't assume that Mailu is the only MTA allowed to send emails on behalf of the domains it hosts.
We should also ensure that it's non-trivial for email-spoofing of hosted domains to happen

Previously we were preventing any spoofing of the envelope from; Now we are preventing spoofing of both the envelope from and the header from unless some form of authentication passes (is a RELAYHOST, SPF, DKIM, ARC)

### Related issue(s)
- close 

## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.

- [x] In case of feature or enhancement: documentation updated accordingly
- [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.


Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
Florent Daigniere c91c9df134 fix error
Alexander Graf e0d2432c6b
Rename data-ordered to data-sort
Alexander Graf 2a4402cdc2
Fix datatable for list fo sign-up domains
Alexander Graf af6cf5fd1d
Fix language selector without session
Alexander Graf 2778641e78
Fix screen reader title of language selector
Alexander Graf 4776094ea7
Configure datatables on missing tables, add sign in button to sso page.
Alexander Graf 6218b36372
configure datatables via html5 data attributes
Alexander Graf 1ae9156756
Add bcyrpt as direct dependency for better crypto. Also some updates
Alexander Graf a74396a9ef
Fix wtforms usage
Alexander Graf 047413185e
Mask Flask-SQLAlchemy >= 3.0.0 for now as it breaks mailu
Alexander Graf 7e36694b64
Update python deps
Alexander Graf 4b179d9008
Merge branch 'master' into hibp
Alexander Graf 36019a8ce9
Don't show Dockerfile before building
Alexander Graf 91e12d510d
Use default password used everywhere else
Alexander Graf defd533319
Don't duplicate hidden fields
Alexander Graf db87a0f3a1
Move temporary db into container and show docker run command
Alexander Graf f7caaddbec
Speed up asset building when developing
Alexander Graf 71263f1a8c
Add more env variables and restyle code
Alexander Graf fd8570ec34
Remove unused QUOTA_STORAGE_URL
Alexander Graf bbeb211d72
Listen to localhost by default
Alexander Graf 1d90dc3ea3
Allow running without redis
Alexander Graf c507b765be
Improve dev runner
Alexander Graf 8732b70b30
Add shell script to run admin dev environment
Alexander Graf ea636a1835
Fix hibp test
Alexander Graf 311f41c331
Add missing hidden fields
Alexander Graf 27a5f9db65
Reformatting
Vincent Kling 83fdc07a6f Default FETCHMAIL_ENABLED to True
Florent Daigniere 54e9858633 this
Florent Daigniere 14f802fb4a untested but that should work
bors[bot] e0ff135a00
Merge
2498: Implement ITERATE in podop r=mergify[bot] a=nextgens

## What type of PR?

Feature

## What does this PR do?

This makes ``doveadm -A`` work.

The easiest way to try it out is:
```
doveadm dict iter proxy:/tmp/podop.socket:auth shared/userdb

or 

doveadm user '*'
```

The protocol is described at https://doc.dovecot.org/developer_manual/design/dict_protocol/
The current version of dovecot is not using flags... so there's little gain in implementing them.

### Related issue(s)
- close 

## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.

- [ ] In case of feature or enhancement: documentation updated accordingly
- [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.


Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
Co-authored-by: Alexander Graf <ghostwheel42@users.noreply.github.com>
Alexander Graf c57706ad27
Duh
Alexander Graf 46773f639b
Return 404 is user-id cannot be parsed
Alexander Graf 595b32cf97
Fix quota return value
Alexander Graf bec0b1c3b2
Fix variable name
Florent Daigniere 001acd60ac doh2
Alexander Graf dec5309ef9
Fix typo
Florent Daigniere 6b7026ef69 Here too
Florent Daigniere 24b2c7c04a doh
Florent Daigniere 66250e396c refactor
wkr d920b3d037 fix(auto-reply): include start and end dates in the auto-reply period; issue
Florent Daigniere ff9f152a52 This may be helpful too
Florent Daigniere 5137b235e9 whitelist what we know works
If other people use other arch and want their builds to go faster we can
whitelist them too after they have confirmed it works.
Alexander Graf a2d43be6de
Fix building wheels when deps need to compile
bors[bot] 659cf8894c
Merge
2502: Resolve using socrate function r=mergify[bot] a=ghostwheel42

## What type of PR?

enhancement

## What does this PR do?

nginx.py had a copy of the socrate function resolve_hostname.
This removes the duplicated code and uses the socrate function.
The socrate functions does the same but prefers ipv4 addresses when resolving.


Co-authored-by: Alexander Graf <ghostwheel42@users.noreply.github.com>
Alexander Graf 91f86a4c2a
Resolve using socrate function
Alexander Graf bba98b320e
Fix armv7 build by manually downloading crates.io index
Florent Daigniere 9cb8df57c6 enforce at least 8 chars
Florent Daigniere afbaabd8cd v1
Florent Daigniere 6def1b555b doh
Florent Daigniere c1f571a4c3 Speed things up.
If we want to go further than this we should change podop's incr(), pass
the flags and make admin process the results.
Florent Daigniere 96d9289630 No need to send an extra \n
Florent Daigniere cdc9b63a46 Guard the message logging too
Florent Daigniere 2a417dbfc2 doesn't belong here
Florent Daigniere 1ce889b91b Do it the pythonic way
Florent Daigniere e10527a4bf This is not used anymore
Florent Daigniere 1ae4c37cb9 Don't do fancy, just re-raise it
Florent Daigniere 5ec4277e1e Make it async. I'm not sure it's a good idea
Florent Daigniere cf34be967c Implement ITERATE
bors[bot] 62c919da09
Merge
2497: Upgrade to alpine 3.16.2 r=mergify[bot] a=nextgens

## What type of PR?

bug-fix

## What does this PR do?

This may fix the build issues on arm (troubles building cryptography)

## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.

- [ ] In case of feature or enhancement: documentation updated accordingly
- [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.


Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
Florent Daigniere 340e359096 doh
Florent Daigniere 076d67b513 follow the protocol
Florent Daigniere 2e467092a2 The newer dovecot sends data podop should ignore
bors[bot] 12480ccbff
Merge
2328: Feature: Configurable default spam threshold used for new users r=mergify[bot] a=enginefeeder101

## What type of PR?

Feature

## What does this PR do?

This PR adds functionality to set a custom default spam threshold
for new users. The environment variable ``DEFAULT_SPAM_THRESHOLD`` is
used for this purpose. When not set, it defaults back to 80%, as the
default value was before.

If ``DEFAULT_SPAM_THRESHOLD`` is set to a value that Python cannot
parse as an integer, a ValueError is thrown. There is no error handling
for that case built-in. Should that be done?

## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.

- [x] In case of feature or enhancement: documentation updated accordingly
- [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.


Co-authored-by: enginefeeder101 <enginefeeder101@users.noreply.github.com>
Co-authored-by: Dimitri Huisman <diman@huisman.xyz>
Florent Daigniere 8942448561 Upgrade to alpine 3.16.2
This may fix the build issues on arm
Dimitri Huisman 06b784da57
Shorten default function by using lambda
bors[bot] 9975a793fe
Merge
2458: Fix: Don't update updated_at on quota_bytes_used change r=mergify[bot] a=DjVinnii

## What type of PR?

bug-fix

## What does this PR do?

This PR makes sure that the `updated_at` field is not updated when `quota_bytes_used` is updated. All other updates to the `User` model still updates the `updated_at` field. 

This is done by explicitly using an method in the `Base` class triggering [`flag_modified`][url-flag-modified].

### Related issue(s)
- closes 

## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.

- [ ] In case of feature or enhancement: documentation updated accordingly
- [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.

<!-- LINKS-->
[url-flag-modified]: https://docs.sqlalchemy.org/en/14/orm/session_api.html#sqlalchemy.orm.attributes.flag_modified


Co-authored-by: Vincent Kling <v.kling@vinniict.nl>
Florent Daigniere ec4224123b Use the logger
bors[bot] 5703e97c73
Merge
2460: Switch to a base image containing base tools and the podop and socrate libs r=mergify[bot] a=ghostwheel42

## What type of PR?

enhancement of build process

## What does this PR do?

Changes build.hcl to build core images using a base image.
Also adds a "assets" base image for the admin container.


Co-authored-by: Alexander Graf <ghostwheel42@users.noreply.github.com>
Co-authored-by: Pierre Jaury <pierre@jaury.eu>
Co-authored-by: kaiyou <pierre@jaury.eu>
Co-authored-by: Dimitri Huisman <52963853+Diman0@users.noreply.github.com>
Alexander Graf 024b0573b3
Update build reqs and fix armv7 build
Vincent Kling 6363acf30a Add dont_change_updated_at to fetch_done
Vincent Kling 6b785abb01 Rename flag_updated_at_as_modified to dont_change_updated_at
Florent Daigniere 89f7d983b4 Don't start rspamd until admin is up and working
Florent Daigniere d8cf0c3848 Revert "Admin may not have started up when this loads"
This reverts commit 0f17299b4e.
Florent Daigniere 0f17299b4e Admin may not have started up when this loads
Florent Daigniere 95a3a3d342 doh
Florent Daigniere 84a722eabc Optimize the query
Florent Daigniere bd1b73032c Poke a hole for mailing lists
Blaž Zupan 56617bbe12 Quote SMTP SIZE to avoid splitting keyword and parameter in EHLO response
Florent Daigniere c4fcaed7d4 doh
Vincent Kling 8a60b658b4 Implement FETCHMAIL_ENABLED
Florent Daigniere 8929f54de5 clarify
Also cover the case where the DKIM sig is for another domain and there
is no explicit DMARC policy
Florent Daigniere 8da6117bb9 clarify
Florent Daigniere af87456faf this works for me
Vincent Kling 23d06a5761 Fix a bunch of typos
Florent Daigniere be4dd6d84a Spell it out
Florent Daigniere f7b3aad831 Ensure we REJECT when we don't have a DMARC policy
This restores the old behaviour
Florent Daigniere 0204c9e59d doh
Florent Daigniere 8775a2bf04 untested code that may just work
Florent Daigniere 5ebcecf4dd Don't need that anymore either
Florent Daigniere 3e51d15b03 Remove the strict anti-spoofing rule.
Alexander Graf d9bf6875e1
Optimize build order for better caching
Alexander Graf 7441a420c4
Fix and speed-up arm build. Allow chosing of prod/dev env.