From 8fc2846924f8148092926a45cf225485970b5ef9 Mon Sep 17 00:00:00 2001 From: Ionut Filip Date: Tue, 18 Dec 2018 17:06:39 +0200 Subject: [PATCH 01/41] Added regex validation for alias username --- core/admin/mailu/ui/forms.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/admin/mailu/ui/forms.py b/core/admin/mailu/ui/forms.py index 57c106c3..40a56a82 100644 --- a/core/admin/mailu/ui/forms.py +++ b/core/admin/mailu/ui/forms.py @@ -136,7 +136,7 @@ class TokenForm(flask_wtf.FlaskForm): class AliasForm(flask_wtf.FlaskForm): - localpart = fields.StringField(_('Alias'), [validators.DataRequired()]) + localpart = fields.StringField(_('Alias'), [validators.DataRequired(), validators.Regexp(LOCALPART_REGEX)]) wildcard = fields.BooleanField( _('Use SQL LIKE Syntax (e.g. for catch-all aliases)')) destination = DestinationField(_('Destination')) From 5e2552bcd57451cc127da1b29575cddd54b95c4d Mon Sep 17 00:00:00 2001 From: Ionut Filip Date: Wed, 19 Dec 2018 12:05:50 +0200 Subject: [PATCH 02/41] Removed if block --- setup/flavors/compose/mailu.env | 2 -- 1 file changed, 2 deletions(-) diff --git a/setup/flavors/compose/mailu.env b/setup/flavors/compose/mailu.env index 11bdbf70..6bdc5e21 100644 --- a/setup/flavors/compose/mailu.env +++ b/setup/flavors/compose/mailu.env @@ -93,13 +93,11 @@ RECIPIENT_DELIMITER={{ recipient_delimiter or '+' }} DMARC_RUA={{ dmarc_rua or 'admin' }} DMARC_RUF={{ dmarc_ruf or 'admin' }} -{% if welcome_enabled %} # Welcome email, enable and set a topic and body if you wish to send welcome # emails to all users. WELCOME={{ welcome_enable or 'false' }} WELCOME_SUBJECT={{ welcome_subject or 'Welcome to your new email account' }} WELCOME_BODY={{ welcome_body or 'Welcome to your new email account, if you can read this, then it is configured properly!' }} -{% endif %} # Maildir Compression # choose compression-method, default: none (value: bz2, gz) From 24828615cf5cec6f0fa13cae588685b4ef9e7ebb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim=20M=C3=B6hlmann?= Date: Wed, 19 Dec 2018 16:20:24 +0200 Subject: [PATCH 03/41] Webmail on root, fixes #757 --- core/nginx/conf/nginx.conf | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/core/nginx/conf/nginx.conf b/core/nginx/conf/nginx.conf index 5dc4e274..c90f7806 100644 --- a/core/nginx/conf/nginx.conf +++ b/core/nginx/conf/nginx.conf @@ -87,14 +87,15 @@ http { include /overrides/*.conf; # Actual logic - + {% if WEB_WEBMAIL != '/' %} location / { - {% if WEBROOT_REDIRECT and WEB_WEBMAIL != '/' %} + {% if WEBROOT_REDIRECT %} return 301 {{ WEBROOT_REDIRECT }}; {% else %} return 404; {% endif %} } + {% endif %} {% if WEBMAIL != 'none' %} location {{ WEB_WEBMAIL }} { From c041a9d45c1e6acd6bec476800d1f09500549e45 Mon Sep 17 00:00:00 2001 From: hoellen Date: Wed, 19 Dec 2018 16:19:37 +0100 Subject: [PATCH 04/41] allow all characters for username in dovecot --- core/dovecot/conf/dovecot.conf | 1 + 1 file changed, 1 insertion(+) diff --git a/core/dovecot/conf/dovecot.conf b/core/dovecot/conf/dovecot.conf index a9ec2676..bc5055d9 100644 --- a/core/dovecot/conf/dovecot.conf +++ b/core/dovecot/conf/dovecot.conf @@ -64,6 +64,7 @@ plugin { ############### # Authentication ############### +auth_username_chars = auth_mechanisms = plain login disable_plaintext_auth = no From af086bbdbea2756e524cca66331dbc43dd3f5e5e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim=20M=C3=B6hlmann?= Date: Thu, 20 Dec 2018 17:47:15 +0200 Subject: [PATCH 05/41] Include DKIM in VOLUME --- core/admin/Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/admin/Dockerfile b/core/admin/Dockerfile index 6fcb4601..95a0705a 100644 --- a/core/admin/Dockerfile +++ b/core/admin/Dockerfile @@ -20,7 +20,7 @@ COPY start.py /start.py RUN pybabel compile -d mailu/translations EXPOSE 80/tcp -VOLUME ["/data"] +VOLUME ["/data","/dkim"] ENV FLASK_APP mailu CMD /start.py From ad1ca42bde0dcbebc68209d896bca3a652d69db1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim=20M=C3=B6hlmann?= Date: Thu, 20 Dec 2018 17:48:29 +0200 Subject: [PATCH 06/41] Remove unused docker socket mount for Admin --- docs/compose/docker-compose.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/compose/docker-compose.yml b/docs/compose/docker-compose.yml index 088d6302..2cff9608 100644 --- a/docs/compose/docker-compose.yml +++ b/docs/compose/docker-compose.yml @@ -88,7 +88,6 @@ services: volumes: - "$ROOT/data:/data" - "$ROOT/dkim:/dkim" - - /var/run/docker.sock:/var/run/docker.sock:ro depends_on: - redis From 736607ab0cec4166ac0d415b9bef724b3cb18fc5 Mon Sep 17 00:00:00 2001 From: Daniel Huber Date: Fri, 21 Dec 2018 15:56:12 +0100 Subject: [PATCH 07/41] Update admin account create command in setup utility to use the flask cli --- setup/flavors/compose/setup.html | 2 +- setup/flavors/stack/setup.html | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/setup/flavors/compose/setup.html b/setup/flavors/compose/setup.html index 3d87a263..0487c98f 100644 --- a/setup/flavors/compose/setup.html +++ b/setup/flavors/compose/setup.html @@ -36,7 +36,7 @@ docker-compose -p mailu up -d Before you can use Mailu, you must create the primary administrator user account. This should be {{ postmaster }}@{{ domain }}. Use the following command, changing PASSWORD to your liking: -
docker-compose -p mailu exec admin python manage.py admin {{ postmaster }} {{ domain }} PASSWORD
+
docker-compose -p mailu exec admin flask mailu admin {{ postmaster }} {{ domain }} PASSWORD
 

Login to the admin interface to change the password for a safe one, at diff --git a/setup/flavors/stack/setup.html b/setup/flavors/stack/setup.html index d68a6422..329a2cba 100644 --- a/setup/flavors/stack/setup.html +++ b/setup/flavors/stack/setup.html @@ -45,7 +45,7 @@ Command for removing docker stack is Before you can use Mailu, you must create the primary administrator user account. This should be {{ postmaster }}@{{ domain }}. Use the following command, changing PASSWORD to your liking: -

docker exec $(docker ps | grep admin | cut -d ' ' -f1) python manage.py admin {{ postmaster }} {{ domain }} PASSWORD 
+
docker exec $(docker ps | grep admin | cut -d ' ' -f1) flask mailu admin {{ postmaster }} {{ domain }} PASSWORD
 

Login to the admin interface to change the password for a safe one, at From d357ed67f5b5a4a5bf01e637eca2c32c650152d4 Mon Sep 17 00:00:00 2001 From: Daniel Huber Date: Fri, 21 Dec 2018 18:13:08 +0100 Subject: [PATCH 08/41] Add DOCKER_PREFIX in tests and setup files --- setup/flavors/compose/docker-compose.yml | 20 ++++++++-------- setup/flavors/stack/docker-compose.yml | 20 ++++++++-------- tests/build.yml | 28 +++++++++++----------- tests/compose/core/docker-compose.yml | 10 ++++---- tests/compose/fetchmail/docker-compose.yml | 12 +++++----- tests/compose/filters/docker-compose.yml | 12 +++++----- tests/compose/rainloop/docker-compose.yml | 12 +++++----- tests/compose/roundcube/docker-compose.yml | 12 +++++----- tests/compose/webdav/docker-compose.yml | 12 +++++----- 9 files changed, 69 insertions(+), 69 deletions(-) diff --git a/setup/flavors/compose/docker-compose.yml b/setup/flavors/compose/docker-compose.yml index d173d4cf..579de56f 100644 --- a/setup/flavors/compose/docker-compose.yml +++ b/setup/flavors/compose/docker-compose.yml @@ -16,7 +16,7 @@ services: # Core services front: - image: ${DOCKER_ORG:-mailu}/nginx:${MAILU_VERSION:-{{ version }}} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}nginx:${MAILU_VERSION:-{{ version }}} restart: always env_file: {{ env }} logging: @@ -36,7 +36,7 @@ services: {% if resolver_enabled %} resolver: - image: mailu/unbound:{{ version }} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}unbound:${MAILU_VERSION:-{{ version }}} env_file: {{ env }} restart: always networks: @@ -45,7 +45,7 @@ services: {% endif %} admin: - image: ${DOCKER_ORG:-mailu}/admin:${MAILU_VERSION:-{{ version }}} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}admin:${MAILU_VERSION:-{{ version }}} restart: always env_file: {{ env }} {% if not admin_enabled %} @@ -59,7 +59,7 @@ services: - redis imap: - image: ${DOCKER_ORG:-mailu}/dovecot:${MAILU_VERSION:-{{ version }}} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}dovecot:${MAILU_VERSION:-{{ version }}} restart: always env_file: {{ env }} volumes: @@ -69,7 +69,7 @@ services: - front smtp: - image: ${DOCKER_ORG:-mailu}/postfix:${MAILU_VERSION:-{{ version }}} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}postfix:${MAILU_VERSION:-{{ version }}} restart: always env_file: {{ env }} volumes: @@ -83,7 +83,7 @@ services: {% endif %} antispam: - image: ${DOCKER_ORG:-mailu}/rspamd:${MAILU_VERSION:-{{ version }}} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}rspamd:${MAILU_VERSION:-{{ version }}} restart: always env_file: {{ env }} volumes: @@ -101,7 +101,7 @@ services: # Optional services {% if antivirus_enabled %} antivirus: - image: ${DOCKER_ORG:-mailu}/clamav:${MAILU_VERSION:-{{ version }}} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}clamav:${MAILU_VERSION:-{{ version }}} restart: always env_file: {{ env }} volumes: @@ -116,7 +116,7 @@ services: {% if webdav_enabled %} webdav: - image: ${DOCKER_ORG:-mailu}/radicale:${MAILU_VERSION:-{{ version }}} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}radicale:${MAILU_VERSION:-{{ version }}} restart: always env_file: {{ env }} volumes: @@ -125,7 +125,7 @@ services: {% if fetchmail_enabled %} fetchmail: - image: ${DOCKER_ORG:-mailu}/fetchmail:${MAILU_VERSION:-{{ version }}} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}fetchmail:${MAILU_VERSION:-{{ version }}} restart: always env_file: {{ env }} {% if resolver_enabled %} @@ -139,7 +139,7 @@ services: # Webmail {% if webmail_type != 'none' %} webmail: - image: ${DOCKER_ORG:-mailu}/{{ webmail_type }}:${MAILU_VERSION:-{{ version }}} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}{{ webmail_type }}:${MAILU_VERSION:-{{ version }}} restart: always env_file: {{ env }} volumes: diff --git a/setup/flavors/stack/docker-compose.yml b/setup/flavors/stack/docker-compose.yml index 217667e1..c7eb5355 100644 --- a/setup/flavors/stack/docker-compose.yml +++ b/setup/flavors/stack/docker-compose.yml @@ -15,7 +15,7 @@ services: # Core services front: - image: ${DOCKER_ORG:-mailu}/nginx:${MAILU_VERSION:-{{ version }}} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}nginx:${MAILU_VERSION:-{{ version }}} env_file: {{ env }} logging: driver: {{ log_driver or 'json-file' }} @@ -33,7 +33,7 @@ services: {% if resolver_enabled %} resolver: - image: ${DOCKER_ORG:-mailu}/unbound:${MAILU_VERSION:-{{ version }}} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}unbound:${MAILU_VERSION:-{{ version }}} env_file: {{ env }} networks: default: @@ -41,7 +41,7 @@ services: {% endif %} admin: - image: ${DOCKER_ORG:-mailu}/admin:${MAILU_VERSION:-{{ version }}} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}admin:${MAILU_VERSION:-{{ version }}} env_file: {{ env }} {% if not admin_enabled %} ports: @@ -54,7 +54,7 @@ services: replicas: {{ admin_replicas }} imap: - image: ${DOCKER_ORG:-mailu}/dovecot:${MAILU_VERSION:-{{ version }}} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}dovecot:${MAILU_VERSION:-{{ version }}} env_file: {{ env }} volumes: - "{{ root }}/mail:/mail" @@ -63,7 +63,7 @@ services: replicas: {{ imap_replicas }} smtp: - image: ${DOCKER_ORG:-mailu}/postfix:${MAILU_VERSION:-{{ version }}} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}postfix:${MAILU_VERSION:-{{ version }}} env_file: {{ env }} volumes: - "{{ root }}/overrides:/overrides" @@ -75,7 +75,7 @@ services: {% endif %} antispam: - image: ${DOCKER_ORG:-mailu}/rspamd:${MAILU_VERSION:-{{ version }}} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}rspamd:${MAILU_VERSION:-{{ version }}} env_file: {{ env }} volumes: - "{{ root }}/filter:/var/lib/rspamd" @@ -91,7 +91,7 @@ services: # Optional services {% if antivirus_enabled %} antivirus: - image: ${DOCKER_ORG:-mailu}/clamav:${MAILU_VERSION:-{{ version }}} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}clamav:${MAILU_VERSION:-{{ version }}} env_file: {{ env }} volumes: - "{{ root }}/filter:/data" @@ -105,7 +105,7 @@ services: {% if webdav_enabled %} webdav: - image: ${DOCKER_ORG:-mailu}/none:${MAILU_VERSION:-{{ version }}} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}none:${MAILU_VERSION:-{{ version }}} env_file: {{ env }} volumes: - "{{ root }}/dav:/data" @@ -115,7 +115,7 @@ services: {% if fetchmail_enabled %} fetchmail: - image: ${DOCKER_ORG:-mailu}/fetchmail:${MAILU_VERSION:-{{ version }}} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}fetchmail:${MAILU_VERSION:-{{ version }}} env_file: {{ env }} volumes: - "{{ root }}/data:/data" @@ -129,7 +129,7 @@ services: {% if webmail_type != 'none' %} webmail: - image: ${DOCKER_ORG:-mailu}/{{ webmail_type }}:${MAILU_VERSION:-{{ version }}} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}{{ webmail_type }}:${MAILU_VERSION:-{{ version }}} env_file: {{ env }} volumes: - "{{ root }}/webmail:/data" diff --git a/tests/build.yml b/tests/build.yml index 0d89c5b8..bec95669 100644 --- a/tests/build.yml +++ b/tests/build.yml @@ -3,61 +3,61 @@ version: '3' services: front: - image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX}nginx:${MAILU_VERSION:-local} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}nginx:${MAILU_VERSION:-local} build: ../core/nginx resolver: - image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX}unbound:${MAILU_VERSION:-local} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}unbound:${MAILU_VERSION:-local} build: ../services/unbound imap: - image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX}dovecot:${MAILU_VERSION:-local} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}dovecot:${MAILU_VERSION:-local} build: ../core/dovecot smtp: - image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX}postfix:${MAILU_VERSION:-local} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}postfix:${MAILU_VERSION:-local} build: ../core/postfix antispam: - image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX}rspamd:${MAILU_VERSION:-local} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}rspamd:${MAILU_VERSION:-local} build: ../services/rspamd antivirus: - image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX}clamav:${MAILU_VERSION:-local} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}clamav:${MAILU_VERSION:-local} build: ../optional/clamav webdav: - image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX}radicale:${MAILU_VERSION:-local} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}radicale:${MAILU_VERSION:-local} build: ../optional/radicale admin: - image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX}admin:${MAILU_VERSION:-local} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}admin:${MAILU_VERSION:-local} build: ../core/admin roundcube: - image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX}roundcube:${MAILU_VERSION:-local} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}roundcube:${MAILU_VERSION:-local} build: ../webmails/roundcube rainloop: - image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX}rainloop:${MAILU_VERSION:-local} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}rainloop:${MAILU_VERSION:-local} build: ../webmails/rainloop fetchmail: - image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX}fetchmail:${MAILU_VERSION:-local} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}fetchmail:${MAILU_VERSION:-local} build: ../services/fetchmail none: - image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX}none:${MAILU_VERSION:-local} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}none:${MAILU_VERSION:-local} build: ../core/none docs: - image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX}docs:${MAILU_VERSION:-local} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}docs:${MAILU_VERSION:-local} build: context: ../docs args: version: ${MAILU_VERSION:-local} setup: - image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX}setup:${MAILU_VERSION:-local} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}setup:${MAILU_VERSION:-local} build: ../setup diff --git a/tests/compose/core/docker-compose.yml b/tests/compose/core/docker-compose.yml index a7c803b7..f64c82b0 100644 --- a/tests/compose/core/docker-compose.yml +++ b/tests/compose/core/docker-compose.yml @@ -15,7 +15,7 @@ services: # Core services front: - image: ${DOCKER_ORG:-mailu}/nginx:${MAILU_VERSION:-master} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}nginx:${MAILU_VERSION:-master} restart: always env_file: mailu.env logging: @@ -34,7 +34,7 @@ services: - "/mailu/certs:/certs" admin: - image: ${DOCKER_ORG:-mailu}/admin:${MAILU_VERSION:-master} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}admin:${MAILU_VERSION:-master} restart: always env_file: mailu.env volumes: @@ -44,7 +44,7 @@ services: - redis imap: - image: ${DOCKER_ORG:-mailu}/dovecot:${MAILU_VERSION:-master} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}dovecot:${MAILU_VERSION:-master} restart: always env_file: mailu.env volumes: @@ -54,7 +54,7 @@ services: - front smtp: - image: ${DOCKER_ORG:-mailu}/postfix:${MAILU_VERSION:-master} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}postfix:${MAILU_VERSION:-master} restart: always env_file: mailu.env volumes: @@ -63,7 +63,7 @@ services: - front antispam: - image: ${DOCKER_ORG:-mailu}/rspamd:${MAILU_VERSION:-master} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}rspamd:${MAILU_VERSION:-master} restart: always env_file: mailu.env volumes: diff --git a/tests/compose/fetchmail/docker-compose.yml b/tests/compose/fetchmail/docker-compose.yml index 505fe21b..49c292e9 100644 --- a/tests/compose/fetchmail/docker-compose.yml +++ b/tests/compose/fetchmail/docker-compose.yml @@ -15,7 +15,7 @@ services: # Core services front: - image: ${DOCKER_ORG:-mailu}/nginx:${MAILU_VERSION:-master} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}nginx:${MAILU_VERSION:-master} restart: always env_file: mailu.env logging: @@ -34,7 +34,7 @@ services: - "/mailu/certs:/certs" admin: - image: ${DOCKER_ORG:-mailu}/admin:${MAILU_VERSION:-master} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}admin:${MAILU_VERSION:-master} restart: always env_file: mailu.env volumes: @@ -44,7 +44,7 @@ services: - redis imap: - image: ${DOCKER_ORG:-mailu}/dovecot:${MAILU_VERSION:-master} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}dovecot:${MAILU_VERSION:-master} restart: always env_file: mailu.env volumes: @@ -54,7 +54,7 @@ services: - front smtp: - image: ${DOCKER_ORG:-mailu}/postfix:${MAILU_VERSION:-master} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}postfix:${MAILU_VERSION:-master} restart: always env_file: mailu.env volumes: @@ -63,7 +63,7 @@ services: - front antispam: - image: ${DOCKER_ORG:-mailu}/rspamd:${MAILU_VERSION:-master} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}rspamd:${MAILU_VERSION:-master} restart: always env_file: mailu.env volumes: @@ -77,7 +77,7 @@ services: fetchmail: - image: ${DOCKER_ORG:-mailu}/fetchmail:${MAILU_VERSION:-master} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}fetchmail:${MAILU_VERSION:-master} restart: always env_file: mailu.env diff --git a/tests/compose/filters/docker-compose.yml b/tests/compose/filters/docker-compose.yml index 463a4384..94b97399 100644 --- a/tests/compose/filters/docker-compose.yml +++ b/tests/compose/filters/docker-compose.yml @@ -15,7 +15,7 @@ services: # Core services front: - image: ${DOCKER_ORG:-mailu}/nginx:${MAILU_VERSION:-master} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}nginx:${MAILU_VERSION:-master} restart: always env_file: mailu.env logging: @@ -34,7 +34,7 @@ services: - "/mailu/certs:/certs" admin: - image: ${DOCKER_ORG:-mailu}/admin:${MAILU_VERSION:-master} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}admin:${MAILU_VERSION:-master} restart: always env_file: mailu.env volumes: @@ -44,7 +44,7 @@ services: - redis imap: - image: ${DOCKER_ORG:-mailu}/dovecot:${MAILU_VERSION:-master} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}dovecot:${MAILU_VERSION:-master} restart: always env_file: mailu.env volumes: @@ -54,7 +54,7 @@ services: - front smtp: - image: ${DOCKER_ORG:-mailu}/postfix:${MAILU_VERSION:-master} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}postfix:${MAILU_VERSION:-master} restart: always env_file: mailu.env volumes: @@ -63,7 +63,7 @@ services: - front antispam: - image: ${DOCKER_ORG:-mailu}/rspamd:${MAILU_VERSION:-master} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}rspamd:${MAILU_VERSION:-master} restart: always env_file: mailu.env volumes: @@ -75,7 +75,7 @@ services: # Optional services antivirus: - image: ${DOCKER_ORG:-mailu}/clamav:${MAILU_VERSION:-master} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}clamav:${MAILU_VERSION:-master} restart: always env_file: mailu.env volumes: diff --git a/tests/compose/rainloop/docker-compose.yml b/tests/compose/rainloop/docker-compose.yml index e7cd577c..98425d7a 100644 --- a/tests/compose/rainloop/docker-compose.yml +++ b/tests/compose/rainloop/docker-compose.yml @@ -15,7 +15,7 @@ services: # Core services front: - image: ${DOCKER_ORG:-mailu}/nginx:${MAILU_VERSION:-master} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}nginx:${MAILU_VERSION:-master} restart: always env_file: mailu.env logging: @@ -34,7 +34,7 @@ services: - "/mailu/certs:/certs" admin: - image: ${DOCKER_ORG:-mailu}/admin:${MAILU_VERSION:-master} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}admin:${MAILU_VERSION:-master} restart: always env_file: mailu.env volumes: @@ -44,7 +44,7 @@ services: - redis imap: - image: ${DOCKER_ORG:-mailu}/dovecot:${MAILU_VERSION:-master} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}dovecot:${MAILU_VERSION:-master} restart: always env_file: mailu.env volumes: @@ -54,7 +54,7 @@ services: - front smtp: - image: ${DOCKER_ORG:-mailu}/postfix:${MAILU_VERSION:-master} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}postfix:${MAILU_VERSION:-master} restart: always env_file: mailu.env volumes: @@ -63,7 +63,7 @@ services: - front antispam: - image: ${DOCKER_ORG:-mailu}/rspamd:${MAILU_VERSION:-master} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}rspamd:${MAILU_VERSION:-master} restart: always env_file: mailu.env volumes: @@ -79,7 +79,7 @@ services: # Webmail webmail: - image: ${DOCKER_ORG:-mailu}/rainloop:${MAILU_VERSION:-master} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}rainloop:${MAILU_VERSION:-master} restart: always env_file: mailu.env volumes: diff --git a/tests/compose/roundcube/docker-compose.yml b/tests/compose/roundcube/docker-compose.yml index 8c34a68b..b2f415df 100644 --- a/tests/compose/roundcube/docker-compose.yml +++ b/tests/compose/roundcube/docker-compose.yml @@ -15,7 +15,7 @@ services: # Core services front: - image: ${DOCKER_ORG:-mailu}/nginx:${MAILU_VERSION:-master} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}nginx:${MAILU_VERSION:-master} restart: always env_file: mailu.env logging: @@ -34,7 +34,7 @@ services: - "/mailu/certs:/certs" admin: - image: ${DOCKER_ORG:-mailu}/admin:${MAILU_VERSION:-master} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}admin:${MAILU_VERSION:-master} restart: always env_file: mailu.env volumes: @@ -44,7 +44,7 @@ services: - redis imap: - image: ${DOCKER_ORG:-mailu}/dovecot:${MAILU_VERSION:-master} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}dovecot:${MAILU_VERSION:-master} restart: always env_file: mailu.env volumes: @@ -54,7 +54,7 @@ services: - front smtp: - image: ${DOCKER_ORG:-mailu}/postfix:${MAILU_VERSION:-master} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}postfix:${MAILU_VERSION:-master} restart: always env_file: mailu.env volumes: @@ -63,7 +63,7 @@ services: - front antispam: - image: ${DOCKER_ORG:-mailu}/rspamd:${MAILU_VERSION:-master} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}rspamd:${MAILU_VERSION:-master} restart: always env_file: mailu.env volumes: @@ -79,7 +79,7 @@ services: # Webmail webmail: - image: ${DOCKER_ORG:-mailu}/roundcube:${MAILU_VERSION:-master} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}roundcube:${MAILU_VERSION:-master} restart: always env_file: mailu.env volumes: diff --git a/tests/compose/webdav/docker-compose.yml b/tests/compose/webdav/docker-compose.yml index e0d5f385..adc094a8 100644 --- a/tests/compose/webdav/docker-compose.yml +++ b/tests/compose/webdav/docker-compose.yml @@ -15,7 +15,7 @@ services: # Core services front: - image: ${DOCKER_ORG:-mailu}/nginx:${MAILU_VERSION:-master} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}nginx:${MAILU_VERSION:-master} restart: always env_file: mailu.env logging: @@ -34,7 +34,7 @@ services: - "/mailu/certs:/certs" admin: - image: ${DOCKER_ORG:-mailu}/admin:${MAILU_VERSION:-master} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}admin:${MAILU_VERSION:-master} restart: always env_file: mailu.env volumes: @@ -44,7 +44,7 @@ services: - redis imap: - image: ${DOCKER_ORG:-mailu}/dovecot:${MAILU_VERSION:-master} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}dovecot:${MAILU_VERSION:-master} restart: always env_file: mailu.env volumes: @@ -54,7 +54,7 @@ services: - front smtp: - image: ${DOCKER_ORG:-mailu}/postfix:${MAILU_VERSION:-master} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}postfix:${MAILU_VERSION:-master} restart: always env_file: mailu.env volumes: @@ -63,7 +63,7 @@ services: - front antispam: - image: ${DOCKER_ORG:-mailu}/rspamd:${MAILU_VERSION:-master} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}rspamd:${MAILU_VERSION:-master} restart: always env_file: mailu.env volumes: @@ -76,7 +76,7 @@ services: # Optional services webdav: - image: ${DOCKER_ORG:-mailu}/radicale:${MAILU_VERSION:-master} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}radicale:${MAILU_VERSION:-master} restart: always env_file: mailu.env volumes: From 3a5b763018d6c2bdda28244901b1e383e6bdfede Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim=20M=C3=B6hlmann?= Date: Tue, 25 Dec 2018 13:52:12 +0200 Subject: [PATCH 09/41] Option to disable full text search (lucene) This is a workaround for the bug in issue #751 --- core/dovecot/conf/dovecot.conf | 2 ++ docs/compose/.env | 4 ++++ 2 files changed, 6 insertions(+) diff --git a/core/dovecot/conf/dovecot.conf b/core/dovecot/conf/dovecot.conf index bc5055d9..83c78f16 100644 --- a/core/dovecot/conf/dovecot.conf +++ b/core/dovecot/conf/dovecot.conf @@ -7,6 +7,7 @@ postmaster_address = {{ POSTMASTER }}@{{ DOMAIN }} hostname = {{ HOSTNAMES.split(",")[0] }} submission_host = {{ FRONT_ADDRESS }} +{% if DISABLE_FTS_LUCENE != 'true' %} ############### # Full-text search ############### @@ -20,6 +21,7 @@ plugin { fts_lucene = whitespace_chars=@. } +{% endif %} ############### # Mailboxes diff --git a/docs/compose/.env b/docs/compose/.env index 73964e3a..836e9dbf 100644 --- a/docs/compose/.env +++ b/docs/compose/.env @@ -3,6 +3,10 @@ # these few settings must however be configured before starting the mail # server and require a restart upon change. +# Set this to `true` to disable full text search by lucene (value: true, false) +# This is a workaround for the bug in issue #751 (indexer-worker crashes) +DISABLE_FTS_LUCENE=false + ################################### # Common configuration variables ################################### From e128d8e975529485e7533766e43e93d1e4376bbc Mon Sep 17 00:00:00 2001 From: Dario Ernst Date: Wed, 5 Dec 2018 21:50:07 +0100 Subject: [PATCH 10/41] Add documentation for usage behind traefik --- docs/reverse.rst | 67 ++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 67 insertions(+) diff --git a/docs/reverse.rst b/docs/reverse.rst index ca68fd7f..cd23aad1 100644 --- a/docs/reverse.rst +++ b/docs/reverse.rst @@ -8,6 +8,7 @@ In such a configuration, one would usually run a frontend reverse proxy to serve There are basically three options, from the most to the least recommended one: - have Mailu Web frontend listen locally and use your own Web frontend on top of it +- use ``Traefik`` in another container as central system-reverse-proxy - override Mailu Web frontend configuration - disable Mailu Web frontend completely and use your own @@ -114,6 +115,72 @@ Depending on how you access the front server, you might want to add a ``proxy_re This will stop redirects (301 and 302) sent by the Webmail, nginx front and admin interface from sending you to ``localhost``. +use ``traefik`` in another container as central system-reverse-proxy +-------------------------------------------------------------------- + +``traefik`` is a popular reverse-proxy aimed at containerized systems. As such, many may wish to integrate ``Mailu`` into a system which already uses ``traefik`` as its sole ingress/reverse-proxy. + +As the ``mailu/front`` container uses ``nginx`` not only for ``HTTP`` forwarding, but also for the mail-protocols like ``SMTP``, ``IMAP``, etc, we need to keep this container around even when using another ``HTTP`` reverse-proxy. Furthermore, ``traefik`` is neither able to forward non-HTTP, nor can it easily forward HTTPS-to-HTTPS. This, however, means 3 things: + +- ``mailu/front`` needs to listen internally on ``HTTP`` rather than ``HTTPS`` +- ``mailu/front`` is not exposed to the outside world on ``HTTP`` +- ``mailu/front`` still needs ``SSL`` certificates (here, we assume ``letsencrypt``) for a well-behaved mail service + +This makes the setup with ``traefik`` a bit harder: ``traefik`` saves its certificates in a proprietary ``JSON`` file, which is not readable by the ``nginx`` in the ``front``-container. To solve this, your ``acme.json`` needs to be exposed to the host or a ``docker-volume``. It will then be read by a script in another container, which will dump the certificates as ``PEM`` files, making them readable for ``nginx``. The `front` container will make sure to reload `nginx` whenever these certificates change. + +To set this up, first set ``TLS_FLAVOR=mail`` in your ``.env``. This tells ``mailu/front`` not to try to request certificates using ``letsencrypt``, but to read provided certificates, and use them only for mail-protocols, not for ``HTTP``. +Next, in your ``docker-compose.yml``, comment out the ``port`` lines of the ``front`` section for port ``…:80`` and ``…:440``. Add the respective traefik labels for your domain/configuration, like + +.. code-block:: yaml + + labels: + - "traefik.enable=true" + - "traefik.port=80" + - "traefik.frontend.rule=Host:$TRAEFIK_DOMAIN" + +**Please don’t forget to add ``TRAEFIK_DOMAIN=[...]`` TO YOUR ``.env``** + +If your ``traefik`` is configured to automatically request certificates from ``letsencrypt``, then you’ll have a certificate for ``mail.your.doma.in`` now. However, ``mail.your.doma.in`` might only be the location where you want the ``Mailu`` web-interfaces to live — your mail should be sent/received from ``your.doma.in``, and this is the ``DOMAIN`` in your ``.env``? +To support that use-case, ``traefik`` can request ``SANs`` for your domain. Lets add something like + +.. code-block:: toml + + [acme] + [[acme.domains]] + main = "your.doma.in" # this is the same as $TRAEFIK_DOMAIN! + sans = ["mail.your.doma.in", "webmail.your.doma.in", "smtp.your.doma.in"] + +to your ``traefik.toml``. You might need to clear your ``acme.json``, if a certificate for one of these domains already exists. + +For the last part, you’re still a bit on your own. You need some solution which dumps the certificates in ``acme.json``, so you can include them in the ``mailu/front`` container. One such example is `traefik-certdumper `, which has been adapted for use in Mailu. You can add it to your ``docker-compose.yml`` like: + +.. code-block:: yaml + + certdumper: + restart: always + image: nebukadneza/traefik-certdumper:latest + environment: + # Make sure this is the same as the main=-domain in traefik.toml + # !!! Also don’t forget to add "TRAEFIK_DOMAIN=[...]" to your .env! + - DOMAIN=$TRAEFIK_DOMAIN + volumes: + - "/data/traefik:/traefik" + - "$ROOT/certs:/output" + + + +assuming you have ``volume-mounted`` your ``acme.json`` put to ``/data/traefik`` on your host. The dumper will then write out ``/data/traefik/ssl/your.doma.in.crt`` and ``/data/traefik/ssl/your.doma.in.key`` whenever ``acme.json`` is updated. Yay! Now let’s mount this to our ``front`` container like: + +.. code-block:: yaml + + volumes: + - "$ROOT/certs:/certs" # Mount both certs directory (for dhparams.pem) and your domains key + - "$ROOT/overrides/nginx:/overrides" + - /data/traefik/ssl/$TRAEFIK_DOMAIN.crt:/certs/cert.pem + - /data/traefik/ssl/$TRAEFIK_DOMAIN.key:/certs/key.pem + + +Note that we still keep the ``$ROOT/certs`` directory-mount there, where ``dhparams.pem`` is going to be placed. Override Mailu configuration ---------------------------- From dc5f5bb023a33d55b1b99a1a4f30407d68390ddf Mon Sep 17 00:00:00 2001 From: Dario Ernst Date: Thu, 6 Dec 2018 09:38:28 +0100 Subject: [PATCH 11/41] Traefik configuration examples --- docs/compose/treafik/docker-compose.yml | 145 ++++++++++++++++++++++++ docs/compose/treafik/traefik.toml | 33 ++++++ 2 files changed, 178 insertions(+) create mode 100644 docs/compose/treafik/docker-compose.yml create mode 100644 docs/compose/treafik/traefik.toml diff --git a/docs/compose/treafik/docker-compose.yml b/docs/compose/treafik/docker-compose.yml new file mode 100644 index 00000000..0dc8369f --- /dev/null +++ b/docs/compose/treafik/docker-compose.yml @@ -0,0 +1,145 @@ +version: '2' + +services: + + # This would normally not be here, but where you define your system services + traefik: + image: traefik:alpine + command: --docker + restart: always + ports: + - "80:80" + - "443:443" + volumes: + - "/var/run/docker.sock:/var/run/docker.sock" + - "/data/traefik/acme.json:/acme.json" + - "/data/traefik/traefik.toml:/traefik.toml" + # This may be needed (plus defining mailu_default external: true) if traefik lives elsewhere + # networks: + # - mailu_default + + certdumper: + restart: always + image: nebukadneza/traefik-certdumper:latest + environment: + # Make sure this is the same as the main=-domain in traefik.toml + # !!! Also don’t forget to add "TRAEFIK_DOMAIN=[...]" to your .env! + - DOMAIN=$TRAEFIK_DOMAIN + volumes: + - "/data/traefik:/traefik" + - "$ROOT/certs:/output" + + front: + image: mailu/nginx:$VERSION + restart: always + env_file: .env + logging: + driver: $LOG_DRIVER + labels: # Traefik labels for simple reverse-proxying + - "traefik.enable=true" + - "traefik.port=80" + - "traefik.frontend.rule=Host:$TRAEFIK_DOMAIN" + - "traefik.docker.network=mailu_default" + ports: + - "80" # Let’s not expose 80 or 443 on host, since that’s taken by traefik + - "$BIND_ADDRESS4:110:110" + - "$BIND_ADDRESS4:143:143" + - "$BIND_ADDRESS4:993:993" + - "$BIND_ADDRESS4:995:995" + - "$BIND_ADDRESS4:25:25" + - "$BIND_ADDRESS4:465:465" + - "$BIND_ADDRESS4:587:587" + - "$BIND_ADDRESS6:110:110" + - "$BIND_ADDRESS6:143:143" + - "$BIND_ADDRESS6:993:993" + - "$BIND_ADDRESS6:995:995" + - "$BIND_ADDRESS6:25:25" + - "$BIND_ADDRESS6:465:465" + - "$BIND_ADDRESS6:587:587" + volumes: + - "$ROOT/certs:/certs" # Mount both certs directory (for dhparams.pem) and your domains key + - "$ROOT/overrides/nginx:/overrides" + - /data/traefik/ssl/$TRAEFIK_DOMAIN.crt:/certs/cert.pem + - /data/traefik/ssl/$TRAEFIK_DOMAIN.key:/certs/key.pem + + redis: + image: redis:alpine + restart: always + volumes: + - "$ROOT/redis:/data" + + imap: + image: mailu/dovecot:$VERSION + restart: always + env_file: .env + volumes: + - "$ROOT/mail:/mail" + - "$ROOT/overrides:/overrides" + depends_on: + - front + + smtp: + image: mailu/postfix:$VERSION + restart: always + env_file: .env + volumes: + - "$ROOT/overrides:/overrides" + depends_on: + - front + + antispam: + image: mailu/rspamd:$VERSION + restart: always + env_file: .env + volumes: + - "$ROOT/filter:/var/lib/rspamd" + - "$ROOT/dkim:/dkim" + - "$ROOT/overrides/rspamd:/etc/rspamd/override.d" + depends_on: + - front + + antivirus: + image: mailu/$ANTIVIRUS:$VERSION + restart: always + env_file: .env + volumes: + - "$ROOT/filter:/data" + + webdav: + image: mailu/$WEBDAV:$VERSION + restart: always + env_file: .env + volumes: + - "$ROOT/dav:/data" + + admin: + image: mailu/admin:$VERSION + restart: always + env_file: .env + volumes: + - "$ROOT/data:/data" + - "$ROOT/dkim:/dkim" + depends_on: + - redis + + webmail: + image: "mailu/$WEBMAIL:$VERSION" + restart: always + env_file: .env + volumes: + - "$ROOT/webmail:/data" + depends_on: + - imap + + fetchmail: + image: mailu/fetchmail:$VERSION + restart: always + env_file: .env + +networks: + default: + driver: bridge + ipam: + driver: default + config: + - subnet: $SUBNET diff --git a/docs/compose/treafik/traefik.toml b/docs/compose/treafik/traefik.toml new file mode 100644 index 00000000..c09cf42a --- /dev/null +++ b/docs/compose/treafik/traefik.toml @@ -0,0 +1,33 @@ +# This is just boilerplate stuff you probably have in your own config +logLevel = "INFO" +defaultEntryPoints = ["https","http"] + +[entryPoints] + [entryPoints.http] + address = ":80" + [entryPoints.http.redirect] + entryPoint = "https" + [entryPoints.https] + address = ":443" + [entryPoints.https.tls] + +[docker] +endpoint = "unix:///var/run/docker.sock" +watch = true +exposedByDefault = false + +# Make sure we get acme.json saved, and onHostRule enabled +[acme] +email = "your@mail.tld" +storage = "acme.json" +entryPoint = "https" +onHostRule = true + +[acme.httpChallenge] +entryPoint = "http" + +# This should include all of your mail domains, and main= should be your $TRAEFIK_DOMAIN +[[acme.domains]] + main = "mail.your.doma.in" + sans = ["web.mail.your.doma.in", "smtp.mail.doma.in", "imap.mail.doma.in"] + From 633919e97cb638125ae82626bcb0596ca20a498c Mon Sep 17 00:00:00 2001 From: Dario Ernst Date: Wed, 26 Dec 2018 11:42:48 +0100 Subject: [PATCH 12/41] Add docker to dump traefiks certificates to pem This is required since traefik sitting on HTTP is able to grab LetsEncrypt certificates which then need to be injected into the front container. --- optional/traefik-certdumper/.dockerignore | 2 ++ optional/traefik-certdumper/Dockerfile | 8 ++++++ optional/traefik-certdumper/LICENSE | 21 ++++++++++++++++ optional/traefik-certdumper/README.md | 27 ++++++++++++++++++++ optional/traefik-certdumper/run.sh | 30 +++++++++++++++++++++++ 5 files changed, 88 insertions(+) create mode 100644 optional/traefik-certdumper/.dockerignore create mode 100644 optional/traefik-certdumper/Dockerfile create mode 100644 optional/traefik-certdumper/LICENSE create mode 100644 optional/traefik-certdumper/README.md create mode 100755 optional/traefik-certdumper/run.sh diff --git a/optional/traefik-certdumper/.dockerignore b/optional/traefik-certdumper/.dockerignore new file mode 100644 index 00000000..9b54c5ba --- /dev/null +++ b/optional/traefik-certdumper/.dockerignore @@ -0,0 +1,2 @@ +README.md +Dockerfile diff --git a/optional/traefik-certdumper/Dockerfile b/optional/traefik-certdumper/Dockerfile new file mode 100644 index 00000000..c8a3aa3f --- /dev/null +++ b/optional/traefik-certdumper/Dockerfile @@ -0,0 +1,8 @@ +FROM alpine + +RUN apk --no-cache add inotify-tools jq openssl util-linux bash docker +# while not strictly documented, this script seems to always(?) support previous acme.json versions too +RUN wget https://raw.githubusercontent.com/containous/traefik/master/contrib/scripts/dumpcerts.sh -O dumpcerts.sh + +COPY run.sh / +ENTRYPOINT ["/run.sh"] diff --git a/optional/traefik-certdumper/LICENSE b/optional/traefik-certdumper/LICENSE new file mode 100644 index 00000000..259ccd34 --- /dev/null +++ b/optional/traefik-certdumper/LICENSE @@ -0,0 +1,21 @@ +MIT License + +Copyright (c) 2018 Sven Dowideit + +Permission is hereby granted, free of charge, to any person obtaining a copy +of this software and associated documentation files (the "Software"), to deal +in the Software without restriction, including without limitation the rights +to use, copy, modify, merge, publish, distribute, sublicense, and/or sell +copies of the Software, and to permit persons to whom the Software is +furnished to do so, subject to the following conditions: + +The above copyright notice and this permission notice shall be included in all +copies or substantial portions of the Software. + +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE +AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, +OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE +SOFTWARE. diff --git a/optional/traefik-certdumper/README.md b/optional/traefik-certdumper/README.md new file mode 100644 index 00000000..f5434f62 --- /dev/null +++ b/optional/traefik-certdumper/README.md @@ -0,0 +1,27 @@ +# Single-domain traefik-certdumper for mailu + +This is based on the work by Sven Dowideit on https://github.com/SvenDowideit/traefik-certdumper + +## Fork? +This is a slight modification that is less flexible, but is adapted to the +usecase in mailu. If you wish to deploy mailu behind a traefik, you face many +problems. One of these is that you need to get the certificates into mailu in a +very defined manner. This will copy the certificate for the **Main:**-domain +given in the DOMAIN-environment onto `output`. + +If your output happens to be mailu-front-`/certs`, the certificate-watcher in +the front-container will catch it and reload nginx. This works for mailu +`TLS_FLAVOR=[mail, cert]` + + +``` + certdumper: + restart: always + image: Mailu/traefik-certdumper:$VERSION + environment: + - DOMAIN=$DOMAIN + volumes: + # your traefik data-volume is probably declared outside of the mailu composefile + - /data/traefik:/traefik + - $ROOT/certs/:/output/ +``` diff --git a/optional/traefik-certdumper/run.sh b/optional/traefik-certdumper/run.sh new file mode 100755 index 00000000..2f73eaf7 --- /dev/null +++ b/optional/traefik-certdumper/run.sh @@ -0,0 +1,30 @@ +#!/bin/bash + +function dump() { + echo "$(date) Dumping certificates" + bash dumpcerts.sh /traefik/acme.json /tmp/work/ + + for crt_file in $(ls /tmp/work/certs/*); do + pem_file=$(echo $crt_file | sed 's/certs/pem/g' | sed 's/.crt/-public.pem/g') + echo "openssl x509 -inform PEM -in $crt_file > $pem_file" + openssl x509 -inform PEM -in $crt_file > $pem_file + done + for key_file in $(ls /tmp/work/private/*); do + pem_file=$(echo $key_file | sed 's/private/pem/g' | sed 's/.key/-private.pem/g') + echo "openssl rsa -in $key_file -text > $pem_file" + openssl rsa -in $key_file -text > $pem_file + done + + echo "$(date) Copying certificates" + cp -v /tmp/work/pem/${DOMAIN}-private.pem /output/key.pem + cp -v /tmp/work/pem/${DOMAIN}-public.pem /output/cert.pem +} + +mkdir -p /tmp/work/pem /tmp/work/certs +# run once on start to make sure we have any old certs +dump + +while true; do + inotifywait -e modify /traefik/acme.json && \ + dump +done From 19bd90f581d799f9150fad5ee48b645f58f366b8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim=20M=C3=B6hlmann?= Date: Thu, 27 Dec 2018 11:50:34 +0200 Subject: [PATCH 13/41] Fix usage of radicale image instead of none I just noticed that the `none` image was used in place where `radicale` should be used. Fixed in this commit. --- setup/flavors/stack/docker-compose.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup/flavors/stack/docker-compose.yml b/setup/flavors/stack/docker-compose.yml index c7eb5355..38c07a40 100644 --- a/setup/flavors/stack/docker-compose.yml +++ b/setup/flavors/stack/docker-compose.yml @@ -105,7 +105,7 @@ services: {% if webdav_enabled %} webdav: - image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}none:${MAILU_VERSION:-{{ version }}} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}radicale:${MAILU_VERSION:-{{ version }}} env_file: {{ env }} volumes: - "{{ root }}/dav:/data" From 5bdbbf60d7874fd45732efd021d57785b20bfa7a Mon Sep 17 00:00:00 2001 From: TheLegend875 <40040530+TheLegend875@users.noreply.github.com> Date: Sat, 22 Dec 2018 22:39:38 +0100 Subject: [PATCH 14/41] fixed display of username when not logged in --- core/admin/mailu/ui/templates/client.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/admin/mailu/ui/templates/client.html b/core/admin/mailu/ui/templates/client.html index 6adc68a2..81bee135 100644 --- a/core/admin/mailu/ui/templates/client.html +++ b/core/admin/mailu/ui/templates/client.html @@ -53,7 +53,7 @@ configure your email client {% trans %}Username{% endtrans %} -

{{ current_user or "******" }}
+
{{ current_user if current_user.is_authenticated else "******" }}
{% trans %}Password{% endtrans %} From e7c9b32e231e533b844a50260e49cb6735b63363 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim=20M=C3=B6hlmann?= Date: Sun, 30 Dec 2018 15:07:45 +0200 Subject: [PATCH 15/41] Restore VERSION_TAG template --- docs/_templates/page.html | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 docs/_templates/page.html diff --git a/docs/_templates/page.html b/docs/_templates/page.html new file mode 100644 index 00000000..97296793 --- /dev/null +++ b/docs/_templates/page.html @@ -0,0 +1,4 @@ +{%- extends "layout.html" %} +{% block body %} + {{ body|replace("VERSION_TAG", version) }} +{% endblock %} From d6ba39b6a9736b9c972781caf7ec6888856713cf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim=20M=C3=B6hlmann?= Date: Sun, 30 Dec 2018 16:49:37 +0200 Subject: [PATCH 16/41] Traefik docs improvements: - Removed code tages to increase readability - Some extra line-breaks for source readability - Fix link to new mailu/traefik-certdumper container - dhparams is no longer stored in /certs - Use a proper "note" box - Fix typo in docs/compose/traefik directory name - Include links to example config files - Fix toml lexer build warning --- .../{treafik => traefik}/docker-compose.yml | 4 +- .../compose/{treafik => traefik}/traefik.toml | 0 docs/reverse.rst | 49 ++++++++++++------- 3 files changed, 32 insertions(+), 21 deletions(-) rename docs/compose/{treafik => traefik}/docker-compose.yml (93%) rename docs/compose/{treafik => traefik}/traefik.toml (100%) diff --git a/docs/compose/treafik/docker-compose.yml b/docs/compose/traefik/docker-compose.yml similarity index 93% rename from docs/compose/treafik/docker-compose.yml rename to docs/compose/traefik/docker-compose.yml index 0dc8369f..607fcaf1 100644 --- a/docs/compose/treafik/docker-compose.yml +++ b/docs/compose/traefik/docker-compose.yml @@ -20,7 +20,7 @@ services: certdumper: restart: always - image: nebukadneza/traefik-certdumper:latest + image: mailu/traefik-certdumper:$VERSION environment: # Make sure this is the same as the main=-domain in traefik.toml # !!! Also don’t forget to add "TRAEFIK_DOMAIN=[...]" to your .env! @@ -41,7 +41,6 @@ services: - "traefik.frontend.rule=Host:$TRAEFIK_DOMAIN" - "traefik.docker.network=mailu_default" ports: - - "80" # Let’s not expose 80 or 443 on host, since that’s taken by traefik - "$BIND_ADDRESS4:110:110" - "$BIND_ADDRESS4:143:143" - "$BIND_ADDRESS4:993:993" @@ -57,7 +56,6 @@ services: - "$BIND_ADDRESS6:465:465" - "$BIND_ADDRESS6:587:587" volumes: - - "$ROOT/certs:/certs" # Mount both certs directory (for dhparams.pem) and your domains key - "$ROOT/overrides/nginx:/overrides" - /data/traefik/ssl/$TRAEFIK_DOMAIN.crt:/certs/cert.pem - /data/traefik/ssl/$TRAEFIK_DOMAIN.key:/certs/key.pem diff --git a/docs/compose/treafik/traefik.toml b/docs/compose/traefik/traefik.toml similarity index 100% rename from docs/compose/treafik/traefik.toml rename to docs/compose/traefik/traefik.toml diff --git a/docs/reverse.rst b/docs/reverse.rst index cd23aad1..5f64b8f3 100644 --- a/docs/reverse.rst +++ b/docs/reverse.rst @@ -115,21 +115,28 @@ Depending on how you access the front server, you might want to add a ``proxy_re This will stop redirects (301 and 302) sent by the Webmail, nginx front and admin interface from sending you to ``localhost``. -use ``traefik`` in another container as central system-reverse-proxy +Use Traefik in another container as central system-reverse-proxy -------------------------------------------------------------------- -``traefik`` is a popular reverse-proxy aimed at containerized systems. As such, many may wish to integrate ``Mailu`` into a system which already uses ``traefik`` as its sole ingress/reverse-proxy. +`Traefik`_ is a popular reverse-proxy aimed at containerized systems. +As such, many may wish to integrate Mailu into a system which already uses Traefik as its sole ingress/reverse-proxy. -As the ``mailu/front`` container uses ``nginx`` not only for ``HTTP`` forwarding, but also for the mail-protocols like ``SMTP``, ``IMAP``, etc, we need to keep this container around even when using another ``HTTP`` reverse-proxy. Furthermore, ``traefik`` is neither able to forward non-HTTP, nor can it easily forward HTTPS-to-HTTPS. This, however, means 3 things: +As the ``mailu/front`` container uses Nginx not only for ``HTTP`` forwarding, but also for the mail-protocols like ``SMTP``, ``IMAP``, etc, we need to keep this +container around even when using another ``HTTP`` reverse-proxy. Furthermore, Traefik is neither able to forward non-HTTP, nor can it easily forward HTTPS-to-HTTPS. +This, however, means 3 things: - ``mailu/front`` needs to listen internally on ``HTTP`` rather than ``HTTPS`` - ``mailu/front`` is not exposed to the outside world on ``HTTP`` - ``mailu/front`` still needs ``SSL`` certificates (here, we assume ``letsencrypt``) for a well-behaved mail service -This makes the setup with ``traefik`` a bit harder: ``traefik`` saves its certificates in a proprietary ``JSON`` file, which is not readable by the ``nginx`` in the ``front``-container. To solve this, your ``acme.json`` needs to be exposed to the host or a ``docker-volume``. It will then be read by a script in another container, which will dump the certificates as ``PEM`` files, making them readable for ``nginx``. The `front` container will make sure to reload `nginx` whenever these certificates change. +This makes the setup with Traefik a bit harder: Traefik saves its certificates in a proprietary *JSON* file, which is not readable by Nginx in the ``front``-container. +To solve this, your ``acme.json`` needs to be exposed to the host or a ``docker-volume``. It will then be read by a script in another container, +which will dump the certificates as ``PEM`` files, readable for Nginx. The ``front`` container will automatically reload Nginx whenever these certificates change. -To set this up, first set ``TLS_FLAVOR=mail`` in your ``.env``. This tells ``mailu/front`` not to try to request certificates using ``letsencrypt``, but to read provided certificates, and use them only for mail-protocols, not for ``HTTP``. -Next, in your ``docker-compose.yml``, comment out the ``port`` lines of the ``front`` section for port ``…:80`` and ``…:440``. Add the respective traefik labels for your domain/configuration, like +To set this up, first set ``TLS_FLAVOR=mail`` in your ``.env``. This tells ``mailu/front`` not to try to request certificates using ``letsencrypt``, +but to read provided certificates, and use them only for mail-protocols, not for ``HTTP``. +Next, in your ``docker-compose.yml``, comment out the ``port`` lines of the ``front`` section for port ``…:80`` and ``…:440``. +Add the respective Traefik labels for your domain/configuration, like .. code-block:: yaml @@ -138,12 +145,14 @@ Next, in your ``docker-compose.yml``, comment out the ``port`` lines of the ``fr - "traefik.port=80" - "traefik.frontend.rule=Host:$TRAEFIK_DOMAIN" -**Please don’t forget to add ``TRAEFIK_DOMAIN=[...]`` TO YOUR ``.env``** +.. note:: Please don’t forget to add ``TRAEFIK_DOMAIN=[...]`` TO YOUR ``.env`` -If your ``traefik`` is configured to automatically request certificates from ``letsencrypt``, then you’ll have a certificate for ``mail.your.doma.in`` now. However, ``mail.your.doma.in`` might only be the location where you want the ``Mailu`` web-interfaces to live — your mail should be sent/received from ``your.doma.in``, and this is the ``DOMAIN`` in your ``.env``? -To support that use-case, ``traefik`` can request ``SANs`` for your domain. Lets add something like +If your Traefik is configured to automatically request certificates from *letsencrypt*, then you’ll have a certificate for ``mail.your.doma.in`` now. However, +``mail.your.doma.in`` might only be the location where you want the Mailu web-interfaces to live — your mail should be sent/received from ``your.doma.in``, +and this is the ``DOMAIN`` in your ``.env``? +To support that use-case, Traefik can request ``SANs`` for your domain. Lets add something like -.. code-block:: toml +.. code-block:: guess [acme] [[acme.domains]] @@ -152,13 +161,14 @@ To support that use-case, ``traefik`` can request ``SANs`` for your domain. Lets to your ``traefik.toml``. You might need to clear your ``acme.json``, if a certificate for one of these domains already exists. -For the last part, you’re still a bit on your own. You need some solution which dumps the certificates in ``acme.json``, so you can include them in the ``mailu/front`` container. One such example is `traefik-certdumper `, which has been adapted for use in Mailu. You can add it to your ``docker-compose.yml`` like: +You will need some solution which dumps the certificates in ``acme.json``, so you can include them in the ``mailu/front`` container. +One such example is ``mailu/traefik-certdumper``, which has been adapted for use in Mailu. You can add it to your ``docker-compose.yml`` like: .. code-block:: yaml certdumper: restart: always - image: nebukadneza/traefik-certdumper:latest + image: mailu/traefik-certdumper:$VERSION environment: # Make sure this is the same as the main=-domain in traefik.toml # !!! Also don’t forget to add "TRAEFIK_DOMAIN=[...]" to your .env! @@ -169,23 +179,23 @@ For the last part, you’re still a bit on your own. You need some solution whic -assuming you have ``volume-mounted`` your ``acme.json`` put to ``/data/traefik`` on your host. The dumper will then write out ``/data/traefik/ssl/your.doma.in.crt`` and ``/data/traefik/ssl/your.doma.in.key`` whenever ``acme.json`` is updated. Yay! Now let’s mount this to our ``front`` container like: +Assuming you have ``volume-mounted`` your ``acme.json`` put to ``/data/traefik`` on your host. The dumper will then write out ``/data/traefik/ssl/your.doma.in.crt`` +and ``/data/traefik/ssl/your.doma.in.key`` whenever ``acme.json`` is updated. Yay! Now let’s mount this to our ``front`` container like: .. code-block:: yaml volumes: - - "$ROOT/certs:/certs" # Mount both certs directory (for dhparams.pem) and your domains key - "$ROOT/overrides/nginx:/overrides" - /data/traefik/ssl/$TRAEFIK_DOMAIN.crt:/certs/cert.pem - /data/traefik/ssl/$TRAEFIK_DOMAIN.key:/certs/key.pem - -Note that we still keep the ``$ROOT/certs`` directory-mount there, where ``dhparams.pem`` is going to be placed. +.. _`Traefik`: https://traefik.io/ Override Mailu configuration ---------------------------- -If you do not have the resources for running a separate reverse proxy, you could override Mailu reverse proxy configuration by using a Docker volume. Simply store your configuration file (Nginx format), in ``/mailu/nginx.conf`` for instance. +If you do not have the resources for running a separate reverse proxy, you could override Mailu reverse proxy configuration by using a Docker volume. +Simply store your configuration file (Nginx format), in ``/mailu/nginx.conf`` for instance. Then modify your ``docker-compose.yml`` file and change the ``front`` section to add a mount: @@ -202,7 +212,10 @@ Then modify your ``docker-compose.yml`` file and change the ``front`` section to - "$ROOT/certs:/certs" - "$ROOT/nginx.conf:/etc/nginx/nginx.conf" -You can use our default configuration file as a sane base for your configuration. +You can also download the example configuration files: + +- :download:`compose/traefik/docker-compose.yml` +- :download:`compose/traefik/traefik.toml` Disable completely Mailu reverse proxy -------------------------------------- From fd23e02aaa25d556403d05f2280a9b16f2a04fde Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim=20M=C3=B6hlmann?= Date: Sun, 30 Dec 2018 16:55:18 +0200 Subject: [PATCH 17/41] Use alpine versioned and defin volumes --- optional/traefik-certdumper/Dockerfile | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/optional/traefik-certdumper/Dockerfile b/optional/traefik-certdumper/Dockerfile index c8a3aa3f..92e5e900 100644 --- a/optional/traefik-certdumper/Dockerfile +++ b/optional/traefik-certdumper/Dockerfile @@ -1,8 +1,11 @@ -FROM alpine +FROM alpine:3.8 RUN apk --no-cache add inotify-tools jq openssl util-linux bash docker # while not strictly documented, this script seems to always(?) support previous acme.json versions too RUN wget https://raw.githubusercontent.com/containous/traefik/master/contrib/scripts/dumpcerts.sh -O dumpcerts.sh +VOLUME ["/traefik"] +VOLUME ["/output"] + COPY run.sh / ENTRYPOINT ["/run.sh"] From 7c7b52d935fbfbd0e90d82c963fa4a70d906045e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim=20M=C3=B6hlmann?= Date: Sun, 30 Dec 2018 17:06:52 +0200 Subject: [PATCH 18/41] Include certdumper in autobuild --- tests/build.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/build.yml b/tests/build.yml index 0d89c5b8..4f6e33de 100644 --- a/tests/build.yml +++ b/tests/build.yml @@ -30,6 +30,10 @@ services: image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX}radicale:${MAILU_VERSION:-local} build: ../optional/radicale + traefik-certdumper: + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX}traefik-certdumper:${MAILU_VERSION:-local} + build: ../optional/traefik-certdumper + admin: image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX}admin:${MAILU_VERSION:-local} build: ../core/admin From a5b96553aac0919fda68b64ef2dab7d2f48a4767 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim=20M=C3=B6hlmann?= Date: Sun, 30 Dec 2018 18:47:12 +0200 Subject: [PATCH 19/41] Check for dumpcerts.sh return status code --- optional/traefik-certdumper/run.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/optional/traefik-certdumper/run.sh b/optional/traefik-certdumper/run.sh index 2f73eaf7..78d20a84 100755 --- a/optional/traefik-certdumper/run.sh +++ b/optional/traefik-certdumper/run.sh @@ -2,7 +2,7 @@ function dump() { echo "$(date) Dumping certificates" - bash dumpcerts.sh /traefik/acme.json /tmp/work/ + bash dumpcerts.sh /traefik/acme.json /tmp/work/ || return for crt_file in $(ls /tmp/work/certs/*); do pem_file=$(echo $crt_file | sed 's/certs/pem/g' | sed 's/.crt/-public.pem/g') From e1902907ff8616bdb64158e82c512b55e9cdcf0d Mon Sep 17 00:00:00 2001 From: hoellen Date: Sun, 30 Dec 2018 18:08:51 +0100 Subject: [PATCH 20/41] Prepare changelog for 1.6 --- CHANGELOG.md | 103 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 103 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2afc69cf..9ced5a79 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,109 @@ Notable changes to this project are documented in the current file. For more details about individual changes, see the Git log. You should read this before upgrading Freposte.io as some changes will include useful notes. +v1.6.0 - unreleased +------------------- + +- Global: Architecture of the central container (#56, #108) +- Global: Serve documentation with docker (#601, #608) +- Global: Travis-CI automated test build (#602) +- Global: Abstract db access from Postfix and Dovecot (#612) +- Global: Refactor the admin architecture and configuration management (#670) +- Feature: Used quota in admin interface (#216) +- Feature: User Signup (#281, #340) +- Feature: Client setup page (#342) +- Feature: Administration setup page (#343) +- Feature: Visual notice whether the mx record points to mailu server (#356) +- Feature: Option for vacation start (#362) +- Feature: Enable enigma in Roundcube (#391) +- Feature: Allow more charcaters as a valid email address (#443) +- Feature: IDNA support (#446) +- Feature: Disable user account (#449) +- Feature: Use fuzzy hashes in rpamd (#456, #527) +- Feature: Enable “doveadm -A” command (#458) +- Feature: Remove the Service Status page (#463) +- Feature: Automated Releases (#487) +- Feature: Support for ARC (#495) +- Feature: Add posibilty to run webmail on root (#501) +- Feature: Upgrade docker-compose.yml to version 3 (#539) +- Feature: Documentation to deploy mailu on a docker swarm (#551) +- Feature: Add full-text search support (#552) +- Feature: Add optional Maildir-Compression (#553) +- Feature: Preserve rspamd history on container restart (#561) +- Feature: FAQ (#564, #677) +- Feature: Kubernetes support (#576) +- Feature: Option to bounce or reject email when recipient is unknown (#583, #626) +- Feature: implement healthchecks for all containers (#631) +- Feature: Option to send front logs to journald or syslog (#584, #661) +- Feature: Support bcrypt and PBKDF2 (#647, #667) +- Feature: enable http2 (#674) +- Feature: Unbound DNS as optional service (#681) +- Feature: Re-write test suite (#682) +- Feature: Docker image prefixes (#702) +- Feature: Add authentication method “login” for Outlook (#704) +- Feature: Allow extending nginx config with overrides (#713) +- Feature: Dynamic attachment size limit (#731) +- Feature: Certificate watcher for external certs to reload nginx (#732) +- Feature: Kubernetes +- Enhancement: Use pre-defined dhparam (#322) +- Enhancement: Disable ssl_session_tickets (#329) +- Enhancement: max attachment size in roundcube (#338) +- Enhancement: Use x-forwarded-proto with redirects (#347) +- Enhancement: Added adress verification before accepting mails for delivery (#353) +- Enhancement: Reverse proxy - Real ip header and mail-letsencrypt (#358) +- Enhancement: Parametrize hosts (#373) +- Enhancement: Expose ports in dockerfiles (#392) +- Enhancement: Added webmail-imap dependency in docker-compose (#403) +- Enhancement: Add environment variables to allow running outside of docker-compose (#429) +- Enhancement: Add original Delivered-To header to received messages (#433) +- Enhancement: Use HOST_ADMIN in "Forwarding authentication server" (#436, #437) +- Enhancement: Use POD_ADDRESS_RANGE for Dovecot (#448) +- Enhancement: Using configurable filenames for TLS certs (#468) +- Enhancement: Don't require BootstrapCDN (GDPR-compliance) (#477) +- Enhancement: Use dynamic client_max_body_size for webmail (#502) +- Enhancement: New logo design (#509) +- Enhancement: New manifests for Kubernetes (#544) +- Enhancement: Pin Alpine image (#548, #557) +- Enhancement: Use safer cipher in roundcube (#597) +- Enhancement: Improve sender checks (#633) +- Enhancement: Use PHP 7.2 for rainloop and roundcube (#606, #642) +- Enhancement: Multi-version documentation (#664) +- Enhancement: Contribution documentation (#700) +- Enhancement: Move Mailu Docker network to a fixed subnet (#727) +- Enhancement: Added regex validation for alias username (#764) +- Enhancement: Update documentation +- Upstream: Update Roundcube +- Upstream: Update Rainloop +- Bug: Rainloop fails with "domain not allowed" (#93) +- Bug: Announces fail (#309) +- Bug: Authentication issues with rspamd admin ui (#315) +- Bug: front hangup on restart (#341) +- Bug: Display the proper user quota when set to 0/infinity (#345) +- Bug: Domain details button "Regenerate keys" when no keys are generated yet (#346) +- Bug: Relayed Domains: access denied error (#351) +- Bug: Do not deny HTTP access upon TLS error when the flavor is mail (#352) +- Bug: php_zip extension missing in Roundcube webmail (#364) +- Bug: RoundCube webmail .htaccess assumes PHP 5 (#366) +- Bug: No quota shows "0 Bytes" in user list (#368) +- Bug: RELAYNETS not honored when login is different from sender (#369) +- Bug: Request Entity Too Large (#371) +- Bug: Pass the full host to the backend (#372) +- Bug: Can't send from an email account that has forwarding (#390) +- Bug: SSL protocol error roundcube/imap (#411, #414) +- Bug: Unable to send from alternative domains (#415) +- Bug: Webadmin redirect ignores host port (#419) +- Bug: Disable esld when signing with dkim (#435) +- Bug: DKIM missing when using identities (#462) +- Bug: Moving mails from Junk to Trash flags them as ham (#474) +- Bug: Cannot set the "keep emails" for fetched accounts (#479) +- Bug: CVE-2018-8740 (#482) +- Bug: Hide administration header in sidebar for normal users (#505) +- Bug: Return correct status codes from auth rate limiter failure (#513) +- Bug: Domain edit page shows "Create" button (#523) +- Bug: Hostname resolving in start.py should retry on failure [docker swarm] (#555) +- Bug: Error when trying to log in with an account without domain (#585) +- Bug: Fix rainloop permissions (#637) + v1.5.1 - 2017-11-21 ------------------- From a7853ff52811464e71b7cc72bafbfc91004ba88d Mon Sep 17 00:00:00 2001 From: hoellen Date: Sun, 30 Dec 2018 18:21:51 +0100 Subject: [PATCH 21/41] link issue to url --- CHANGELOG.md | 190 +++++++++++++++++++++++++-------------------------- 1 file changed, 95 insertions(+), 95 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9ced5a79..f3bcce93 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,105 +8,105 @@ upgrading Freposte.io as some changes will include useful notes. v1.6.0 - unreleased ------------------- -- Global: Architecture of the central container (#56, #108) -- Global: Serve documentation with docker (#601, #608) -- Global: Travis-CI automated test build (#602) -- Global: Abstract db access from Postfix and Dovecot (#612) -- Global: Refactor the admin architecture and configuration management (#670) -- Feature: Used quota in admin interface (#216) -- Feature: User Signup (#281, #340) -- Feature: Client setup page (#342) -- Feature: Administration setup page (#343) -- Feature: Visual notice whether the mx record points to mailu server (#356) -- Feature: Option for vacation start (#362) -- Feature: Enable enigma in Roundcube (#391) -- Feature: Allow more charcaters as a valid email address (#443) -- Feature: IDNA support (#446) -- Feature: Disable user account (#449) -- Feature: Use fuzzy hashes in rpamd (#456, #527) -- Feature: Enable “doveadm -A” command (#458) -- Feature: Remove the Service Status page (#463) -- Feature: Automated Releases (#487) -- Feature: Support for ARC (#495) -- Feature: Add posibilty to run webmail on root (#501) -- Feature: Upgrade docker-compose.yml to version 3 (#539) -- Feature: Documentation to deploy mailu on a docker swarm (#551) -- Feature: Add full-text search support (#552) -- Feature: Add optional Maildir-Compression (#553) -- Feature: Preserve rspamd history on container restart (#561) -- Feature: FAQ (#564, #677) -- Feature: Kubernetes support (#576) -- Feature: Option to bounce or reject email when recipient is unknown (#583, #626) -- Feature: implement healthchecks for all containers (#631) -- Feature: Option to send front logs to journald or syslog (#584, #661) -- Feature: Support bcrypt and PBKDF2 (#647, #667) -- Feature: enable http2 (#674) -- Feature: Unbound DNS as optional service (#681) -- Feature: Re-write test suite (#682) -- Feature: Docker image prefixes (#702) -- Feature: Add authentication method “login” for Outlook (#704) -- Feature: Allow extending nginx config with overrides (#713) -- Feature: Dynamic attachment size limit (#731) -- Feature: Certificate watcher for external certs to reload nginx (#732) +- Global: Architecture of the central container ([#56](https://github.com/Mailu/Mailu/issues/56), [#108](https://github.com/Mailu/Mailu/issues/108)) +- Global: Serve documentation with docker ([#601](https://github.com/Mailu/Mailu/issues/601), [#608](https://github.com/Mailu/Mailu/issues/608)) +- Global: Travis-CI automated test build ([#602](https://github.com/Mailu/Mailu/issues/602)) +- Global: Abstract db access from Postfix and Dovecot ([#612](https://github.com/Mailu/Mailu/issues/612)) +- Global: Refactor the admin architecture and configuration management ([#670](https://github.com/Mailu/Mailu/issues/670)) +- Feature: Used quota in admin interface ([#216](https://github.com/Mailu/Mailu/issues/216)) +- Feature: User Signup ([#281](https://github.com/Mailu/Mailu/issues/281), [#340](https://github.com/Mailu/Mailu/issues/340)) +- Feature: Client setup page ([#342](https://github.com/Mailu/Mailu/issues/342)) +- Feature: Administration setup page ([#343](https://github.com/Mailu/Mailu/issues/343)) +- Feature: Visual notice whether the mx record points to mailu server ([#356](https://github.com/Mailu/Mailu/issues/356)) +- Feature: Option for vacation start ([#362](https://github.com/Mailu/Mailu/issues/362)) +- Feature: Enable enigma in Roundcube ([#391](https://github.com/Mailu/Mailu/issues/391)) +- Feature: Allow more charcaters as a valid email address ([#443](https://github.com/Mailu/Mailu/issues/443)) +- Feature: IDNA support ([#446](https://github.com/Mailu/Mailu/issues/446)) +- Feature: Disable user account ([#449](https://github.com/Mailu/Mailu/issues/449)) +- Feature: Use fuzzy hashes in rpamd ([#456](https://github.com/Mailu/Mailu/issues/456), [#527](https://github.com/Mailu/Mailu/issues/527)) +- Feature: Enable “doveadm -A” command ([#458](https://github.com/Mailu/Mailu/issues/458)) +- Feature: Remove the Service Status page ([#463](https://github.com/Mailu/Mailu/issues/463)) +- Feature: Automated Releases ([#487](https://github.com/Mailu/Mailu/issues/487)) +- Feature: Support for ARC ([#495](https://github.com/Mailu/Mailu/issues/495)) +- Feature: Add posibilty to run webmail on root ([#501](https://github.com/Mailu/Mailu/issues/501)) +- Feature: Upgrade docker-compose.yml to version 3 ([#539](https://github.com/Mailu/Mailu/issues/539)) +- Feature: Documentation to deploy mailu on a docker swarm ([#551](https://github.com/Mailu/Mailu/issues/551)) +- Feature: Add full-text search support ([#552](https://github.com/Mailu/Mailu/issues/552)) +- Feature: Add optional Maildir-Compression ([#553](https://github.com/Mailu/Mailu/issues/553)) +- Feature: Preserve rspamd history on container restart ([#561](https://github.com/Mailu/Mailu/issues/561)) +- Feature: FAQ ([#564](https://github.com/Mailu/Mailu/issues/564), [#677](https://github.com/Mailu/Mailu/issues/677)) +- Feature: Kubernetes support ([#576](https://github.com/Mailu/Mailu/issues/576)) +- Feature: Option to bounce or reject email when recipient is unknown ([#583](https://github.com/Mailu/Mailu/issues/583), [#626](https://github.com/Mailu/Mailu/issues/626)) +- Feature: implement healthchecks for all containers ([#631](https://github.com/Mailu/Mailu/issues/631)) +- Feature: Option to send front logs to journald or syslog ([#584](https://github.com/Mailu/Mailu/issues/584), [#661](https://github.com/Mailu/Mailu/issues/661)) +- Feature: Support bcrypt and PBKDF2 ([#647](https://github.com/Mailu/Mailu/issues/647), [#667](https://github.com/Mailu/Mailu/issues/667)) +- Feature: enable http2 ([#674](https://github.com/Mailu/Mailu/issues/674)) +- Feature: Unbound DNS as optional service ([#681](https://github.com/Mailu/Mailu/issues/681)) +- Feature: Re-write test suite ([#682](https://github.com/Mailu/Mailu/issues/682)) +- Feature: Docker image prefixes ([#702](https://github.com/Mailu/Mailu/issues/702)) +- Feature: Add authentication method “login” for Outlook ([#704](https://github.com/Mailu/Mailu/issues/704)) +- Feature: Allow extending nginx config with overrides ([#713](https://github.com/Mailu/Mailu/issues/713)) +- Feature: Dynamic attachment size limit ([#731](https://github.com/Mailu/Mailu/issues/731)) +- Feature: Certificate watcher for external certs to reload nginx ([#732](https://github.com/Mailu/Mailu/issues/732)) - Feature: Kubernetes -- Enhancement: Use pre-defined dhparam (#322) -- Enhancement: Disable ssl_session_tickets (#329) -- Enhancement: max attachment size in roundcube (#338) -- Enhancement: Use x-forwarded-proto with redirects (#347) -- Enhancement: Added adress verification before accepting mails for delivery (#353) -- Enhancement: Reverse proxy - Real ip header and mail-letsencrypt (#358) -- Enhancement: Parametrize hosts (#373) -- Enhancement: Expose ports in dockerfiles (#392) -- Enhancement: Added webmail-imap dependency in docker-compose (#403) -- Enhancement: Add environment variables to allow running outside of docker-compose (#429) -- Enhancement: Add original Delivered-To header to received messages (#433) -- Enhancement: Use HOST_ADMIN in "Forwarding authentication server" (#436, #437) -- Enhancement: Use POD_ADDRESS_RANGE for Dovecot (#448) -- Enhancement: Using configurable filenames for TLS certs (#468) -- Enhancement: Don't require BootstrapCDN (GDPR-compliance) (#477) -- Enhancement: Use dynamic client_max_body_size for webmail (#502) -- Enhancement: New logo design (#509) -- Enhancement: New manifests for Kubernetes (#544) -- Enhancement: Pin Alpine image (#548, #557) -- Enhancement: Use safer cipher in roundcube (#597) -- Enhancement: Improve sender checks (#633) -- Enhancement: Use PHP 7.2 for rainloop and roundcube (#606, #642) -- Enhancement: Multi-version documentation (#664) -- Enhancement: Contribution documentation (#700) -- Enhancement: Move Mailu Docker network to a fixed subnet (#727) -- Enhancement: Added regex validation for alias username (#764) +- Enhancement: Use pre-defined dhparam ([#322](https://github.com/Mailu/Mailu/issues/322)) +- Enhancement: Disable ssl_session_tickets ([#329](https://github.com/Mailu/Mailu/issues/329)) +- Enhancement: max attachment size in roundcube ([#338](https://github.com/Mailu/Mailu/issues/338)) +- Enhancement: Use x-forwarded-proto with redirects ([#347](https://github.com/Mailu/Mailu/issues/347)) +- Enhancement: Added adress verification before accepting mails for delivery ([#353](https://github.com/Mailu/Mailu/issues/353)) +- Enhancement: Reverse proxy - Real ip header and mail-letsencrypt ([#358](https://github.com/Mailu/Mailu/issues/358)) +- Enhancement: Parametrize hosts ([#373](https://github.com/Mailu/Mailu/issues/373)) +- Enhancement: Expose ports in dockerfiles ([#392](https://github.com/Mailu/Mailu/issues/392)) +- Enhancement: Added webmail-imap dependency in docker-compose ([#403](https://github.com/Mailu/Mailu/issues/403)) +- Enhancement: Add environment variables to allow running outside of docker-compose ([#429](https://github.com/Mailu/Mailu/issues/429)) +- Enhancement: Add original Delivered-To header to received messages ([#433](https://github.com/Mailu/Mailu/issues/433)) +- Enhancement: Use HOST_ADMIN in "Forwarding authentication server" ([#436](https://github.com/Mailu/Mailu/issues/436), [#437](https://github.com/Mailu/Mailu/issues/437)) +- Enhancement: Use POD_ADDRESS_RANGE for Dovecot ([#448](https://github.com/Mailu/Mailu/issues/448)) +- Enhancement: Using configurable filenames for TLS certs ([#468](https://github.com/Mailu/Mailu/issues/468)) +- Enhancement: Don't require BootstrapCDN (GDPR-compliance) ([#477](https://github.com/Mailu/Mailu/issues/477)) +- Enhancement: Use dynamic client_max_body_size for webmail ([#502](https://github.com/Mailu/Mailu/issues/502)) +- Enhancement: New logo design ([#509](https://github.com/Mailu/Mailu/issues/509)) +- Enhancement: New manifests for Kubernetes ([#544](https://github.com/Mailu/Mailu/issues/544)) +- Enhancement: Pin Alpine image ([#548](https://github.com/Mailu/Mailu/issues/548), [#557](https://github.com/Mailu/Mailu/issues/557)) +- Enhancement: Use safer cipher in roundcube ([#597](https://github.com/Mailu/Mailu/issues/597)) +- Enhancement: Improve sender checks ([#633](https://github.com/Mailu/Mailu/issues/633)) +- Enhancement: Use PHP 7.2 for rainloop and roundcube ([#606](https://github.com/Mailu/Mailu/issues/606), [#642](https://github.com/Mailu/Mailu/issues/642)) +- Enhancement: Multi-version documentation ([#664](https://github.com/Mailu/Mailu/issues/664)) +- Enhancement: Contribution documentation ([#700](https://github.com/Mailu/Mailu/issues/700)) +- Enhancement: Move Mailu Docker network to a fixed subnet ([#727](https://github.com/Mailu/Mailu/issues/727)) +- Enhancement: Added regex validation for alias username ([#764](https://github.com/Mailu/Mailu/issues/764)) - Enhancement: Update documentation - Upstream: Update Roundcube - Upstream: Update Rainloop -- Bug: Rainloop fails with "domain not allowed" (#93) -- Bug: Announces fail (#309) -- Bug: Authentication issues with rspamd admin ui (#315) -- Bug: front hangup on restart (#341) -- Bug: Display the proper user quota when set to 0/infinity (#345) -- Bug: Domain details button "Regenerate keys" when no keys are generated yet (#346) -- Bug: Relayed Domains: access denied error (#351) -- Bug: Do not deny HTTP access upon TLS error when the flavor is mail (#352) -- Bug: php_zip extension missing in Roundcube webmail (#364) -- Bug: RoundCube webmail .htaccess assumes PHP 5 (#366) -- Bug: No quota shows "0 Bytes" in user list (#368) -- Bug: RELAYNETS not honored when login is different from sender (#369) -- Bug: Request Entity Too Large (#371) -- Bug: Pass the full host to the backend (#372) -- Bug: Can't send from an email account that has forwarding (#390) -- Bug: SSL protocol error roundcube/imap (#411, #414) -- Bug: Unable to send from alternative domains (#415) -- Bug: Webadmin redirect ignores host port (#419) -- Bug: Disable esld when signing with dkim (#435) -- Bug: DKIM missing when using identities (#462) -- Bug: Moving mails from Junk to Trash flags them as ham (#474) -- Bug: Cannot set the "keep emails" for fetched accounts (#479) -- Bug: CVE-2018-8740 (#482) -- Bug: Hide administration header in sidebar for normal users (#505) -- Bug: Return correct status codes from auth rate limiter failure (#513) -- Bug: Domain edit page shows "Create" button (#523) -- Bug: Hostname resolving in start.py should retry on failure [docker swarm] (#555) -- Bug: Error when trying to log in with an account without domain (#585) -- Bug: Fix rainloop permissions (#637) +- Bug: Rainloop fails with "domain not allowed" ([#93](https://github.com/Mailu/Mailu/issues/93)) +- Bug: Announces fail ([#309](https://github.com/Mailu/Mailu/issues/309)) +- Bug: Authentication issues with rspamd admin ui ([#315](https://github.com/Mailu/Mailu/issues/315)) +- Bug: front hangup on restart ([#341](https://github.com/Mailu/Mailu/issues/341)) +- Bug: Display the proper user quota when set to 0/infinity ([#345](https://github.com/Mailu/Mailu/issues/345)) +- Bug: Domain details button "Regenerate keys" when no keys are generated yet ([#346](https://github.com/Mailu/Mailu/issues/346)) +- Bug: Relayed Domains: access denied error ([#351](https://github.com/Mailu/Mailu/issues/351)) +- Bug: Do not deny HTTP access upon TLS error when the flavor is mail ([#352](https://github.com/Mailu/Mailu/issues/352)) +- Bug: php_zip extension missing in Roundcube webmail ([#364](https://github.com/Mailu/Mailu/issues/364)) +- Bug: RoundCube webmail .htaccess assumes PHP 5 ([#366](https://github.com/Mailu/Mailu/issues/366)) +- Bug: No quota shows "0 Bytes" in user list ([#368](https://github.com/Mailu/Mailu/issues/368)) +- Bug: RELAYNETS not honored when login is different from sender ([#369](https://github.com/Mailu/Mailu/issues/369)) +- Bug: Request Entity Too Large ([#371](https://github.com/Mailu/Mailu/issues/371)) +- Bug: Pass the full host to the backend ([#372](https://github.com/Mailu/Mailu/issues/372)) +- Bug: Can't send from an email account that has forwarding ([#390](https://github.com/Mailu/Mailu/issues/390)) +- Bug: SSL protocol error roundcube/imap ([#411](https://github.com/Mailu/Mailu/issues/411), [#414](https://github.com/Mailu/Mailu/issues/414)) +- Bug: Unable to send from alternative domains ([#415](https://github.com/Mailu/Mailu/issues/415)) +- Bug: Webadmin redirect ignores host port ([#419](https://github.com/Mailu/Mailu/issues/419)) +- Bug: Disable esld when signing with dkim ([#435](https://github.com/Mailu/Mailu/issues/435)) +- Bug: DKIM missing when using identities ([#462](https://github.com/Mailu/Mailu/issues/462)) +- Bug: Moving mails from Junk to Trash flags them as ham ([#474](https://github.com/Mailu/Mailu/issues/474)) +- Bug: Cannot set the "keep emails" for fetched accounts ([#479](https://github.com/Mailu/Mailu/issues/479)) +- Bug: CVE-2018-8740 ([#482](https://github.com/Mailu/Mailu/issues/482)) +- Bug: Hide administration header in sidebar for normal users ([#505](https://github.com/Mailu/Mailu/issues/505)) +- Bug: Return correct status codes from auth rate limiter failure ([#513](https://github.com/Mailu/Mailu/issues/513)) +- Bug: Domain edit page shows "Create" button ([#523](https://github.com/Mailu/Mailu/issues/523)) +- Bug: Hostname resolving in start.py should retry on failure [docker swarm] ([#555](https://github.com/Mailu/Mailu/issues/555)) +- Bug: Error when trying to log in with an account without domain ([#585](https://github.com/Mailu/Mailu/issues/585)) +- Bug: Fix rainloop permissions ([#637](https://github.com/Mailu/Mailu/issues/637)) v1.5.1 - 2017-11-21 ------------------- From aefb638eca56b8ba4bb8f2e4b16fb68a454a73eb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim=20M=C3=B6hlmann?= Date: Sun, 30 Dec 2018 21:08:29 +0200 Subject: [PATCH 22/41] Fix links to documentation --- CONTRIBUTING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 4a7611f0..ff7939e5 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,7 +1,7 @@ This project is open source, and your contributions are all welcome. There are mostly three different ways one can contribute to the project: 1. use Mailu, either on test or on production instances, and report meaningful bugs when you find some; -2. contribute code and/or configuration to the repository (see [the development guidelines](https://mailu.io/contributors/guide.html) for details); -3. contribute localization to your native language (see [the localization docs](https://mailu.io/contributors/localization.html) for details); +2. contribute code and/or configuration to the repository (see [the development guidelines](https://mailu.io/master/contributors/guide.html) for details); +3. contribute localization to your native language (see [the localization docs](https://mailu.io/master/contributors/localization.html) for details); Either way, keep in mind that the code you write or the translation you produce muts be licensed under the same conditions as the project itself. Additionally, all contributors are considered equal co-authors of the project. From 2dfed9dc908a2765c779cac495f7461b1fb12110 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim=20M=C3=B6hlmann?= Date: Sun, 30 Dec 2018 21:15:41 +0200 Subject: [PATCH 23/41] Add usrpro team to authors --- AUTHORS.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/AUTHORS.md b/AUTHORS.md index f62c2e14..11aca2a4 100644 --- a/AUTHORS.md +++ b/AUTHORS.md @@ -22,3 +22,5 @@ Other contributors: - "SunMar" - Dutch translation - "Marty Hou" - Chinese Simple translation - [Thomas Sänger](https://github.com/HorayNarea) - German translation + - [Tim Mohlmann](https://github.com/muhlemmer) - [Contributions](https://github.com/Mailu/Mailu/commits?author=muhlemmer) + - [Ionut Filip](https://github.com/ionutfilip) - [Contributions](https://github.com/Mailu/Mailu/commits?author=ionutfilip) From 03ee3aa918a77d9f4136c14c8a61eb97ebc48910 Mon Sep 17 00:00:00 2001 From: Dario Ernst Date: Sun, 30 Dec 2018 21:46:02 +0100 Subject: [PATCH 24/41] Fix typo in contributor docs --- docs/contributors/environment.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/contributors/environment.rst b/docs/contributors/environment.rst index b539293b..263ef747 100644 --- a/docs/contributors/environment.rst +++ b/docs/contributors/environment.rst @@ -184,7 +184,7 @@ directory structure. If you do no posses the resources, but want to become an involved tester/reviewer. Please contact `muhlemmer on Matrix`_. -He can provide access to a testing server, if a thrust relation can be established. +He can provide access to a testing server, if a trust relation can be established. .. _`muhlemmer on Matrix`: https://matrix.to/#/@muhlemmer:matrix.org From 56f4d4c89456e13e8d9558dcb7b679dab7e02c5e Mon Sep 17 00:00:00 2001 From: TheLegend875 Date: Fri, 28 Dec 2018 21:03:57 +0100 Subject: [PATCH 25/41] fixed auto-forward --- core/admin/mailu/models.py | 2 +- core/admin/mailu/ui/forms.py | 12 +++++++++--- core/admin/mailu/ui/views/users.py | 8 +++++++- 3 files changed, 17 insertions(+), 5 deletions(-) diff --git a/core/admin/mailu/models.py b/core/admin/mailu/models.py index a3fc15a4..30a2ed64 100644 --- a/core/admin/mailu/models.py +++ b/core/admin/mailu/models.py @@ -72,7 +72,7 @@ class CommaSeparatedList(db.TypeDecorator): return ",".join(value) def process_result_value(self, value, dialect): - return filter(bool, value.split(",")) if value else [] + return list(filter(bool, value.split(","))) if value else [] class JSONEncoded(db.TypeDecorator): diff --git a/core/admin/mailu/ui/forms.py b/core/admin/mailu/ui/forms.py index 40a56a82..ac4f0e19 100644 --- a/core/admin/mailu/ui/forms.py +++ b/core/admin/mailu/ui/forms.py @@ -32,6 +32,14 @@ class DestinationField(fields.SelectMultipleField): if not self.validator.match(item): raise validators.ValidationError(_('Invalid email address.')) +class MultipleEmailAddressesVerify(object): + def __init__(self,message=_('Invalid email address.')): + self.message = message + + def __call__(self, form, field): + pattern = re.compile(r'^([_a-z0-9\-]+)(\.[_a-z0-9\-]+)*@([a-z0-9\-]{2,}\.)*([a-z]{2,4})(,([_a-z0-9\-]+)(\.[_a-z0-9\-]+)*@([a-z0-9\-]{2,}\.)*([a-z]{2,4}))*$') + if not pattern.match(field.data.replace(" ", "")): + raise validators.ValidationError(self.message) class ConfirmationForm(flask_wtf.FlaskForm): submit = fields.SubmitField(_('Confirm')) @@ -101,9 +109,7 @@ class UserSettingsForm(flask_wtf.FlaskForm): spam_threshold = fields_.IntegerSliderField(_('Spam filter tolerance')) forward_enabled = fields.BooleanField(_('Enable forwarding')) forward_keep = fields.BooleanField(_('Keep a copy of the emails')) - forward_destination = fields.StringField( - _('Destination'), [validators.Optional(), validators.Email()] - ) + forward_destination = fields.StringField(_('Destination'), [validators.Optional(), MultipleEmailAddressesVerify()]) submit = fields.SubmitField(_('Save settings')) diff --git a/core/admin/mailu/ui/views/users.py b/core/admin/mailu/ui/views/users.py index 51dfdc13..4cbe7a97 100644 --- a/core/admin/mailu/ui/views/users.py +++ b/core/admin/mailu/ui/views/users.py @@ -7,7 +7,6 @@ import flask_login import wtforms import wtforms_components - @ui.route('/user/list/', methods=['GET']) @access.domain_admin(models.Domain, 'domain_name') def user_list(domain_name): @@ -92,9 +91,16 @@ def user_settings(user_email): user_email_or_current = user_email or flask_login.current_user.email user = models.User.query.get(user_email_or_current) or flask.abort(404) form = forms.UserSettingsForm(obj=user) + if isinstance(form.forward_destination.data,str): + data = form.forward_destination.data.replace(" ","").split(",") + else: + data = form.forward_destination.data + form.forward_destination.data = ", ".join(data) if form.validate_on_submit(): + form.forward_destination.data = form.forward_destination.data.replace(" ","").split(",") form.populate_obj(user) models.db.session.commit() + form.forward_destination.data = ", ".join(form.forward_destination.data) flask.flash('Settings updated for %s' % user) if user_email: return flask.redirect( From 2954d8479008e2205cf59958ae073b05051180cc Mon Sep 17 00:00:00 2001 From: TheLegend875 Date: Sun, 30 Dec 2018 20:29:41 +0100 Subject: [PATCH 26/41] added necessary ui elements --- core/admin/mailu/ui/forms.py | 1 + core/admin/mailu/ui/templates/user/create.html | 1 + core/admin/mailu/ui/templates/user/settings.html | 4 ++++ 3 files changed, 6 insertions(+) diff --git a/core/admin/mailu/ui/forms.py b/core/admin/mailu/ui/forms.py index 40a56a82..e021cd60 100644 --- a/core/admin/mailu/ui/forms.py +++ b/core/admin/mailu/ui/forms.py @@ -81,6 +81,7 @@ class UserForm(flask_wtf.FlaskForm): quota_bytes = fields_.IntegerSliderField(_('Quota'), default=1000000000) enable_imap = fields.BooleanField(_('Allow IMAP access'), default=True) enable_pop = fields.BooleanField(_('Allow POP3 access'), default=True) + displayed_name = fields.StringField(_('Displayed name')) comment = fields.StringField(_('Comment')) enabled = fields.BooleanField(_('Enabled'), default=True) submit = fields.SubmitField(_('Save')) diff --git a/core/admin/mailu/ui/templates/user/create.html b/core/admin/mailu/ui/templates/user/create.html index 09e83155..ed7b9884 100644 --- a/core/admin/mailu/ui/templates/user/create.html +++ b/core/admin/mailu/ui/templates/user/create.html @@ -15,6 +15,7 @@ {% call macros.box(_("General")) %} {{ macros.form_field(form.localpart, append='@'+domain.name+'') }} {{ macros.form_fields((form.pw, form.pw2)) }} + {{ macros.form_field(form.displayed_name) }} {{ macros.form_field(form.comment) }} {{ macros.form_field(form.enabled) }} {% endcall %} diff --git a/core/admin/mailu/ui/templates/user/settings.html b/core/admin/mailu/ui/templates/user/settings.html index e14d2d70..b6ade695 100644 --- a/core/admin/mailu/ui/templates/user/settings.html +++ b/core/admin/mailu/ui/templates/user/settings.html @@ -11,6 +11,10 @@ {% block content %}
{{ form.hidden_tag() }} + + {% call macros.box(title=_("Displayed name")) %} + {{ macros.form_field(form.displayed_name) }} + {% endcall %} {% call macros.box(title=_("Antispam")) %} {{ macros.form_field(form.spam_enabled) }} From 999d2a9557ad2cb46cb5672ec4223dbda3945399 Mon Sep 17 00:00:00 2001 From: TheLegend875 Date: Sun, 30 Dec 2018 21:44:38 +0100 Subject: [PATCH 27/41] changed default.sieve to send displayed name --- core/admin/mailu/internal/templates/default.sieve | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/admin/mailu/internal/templates/default.sieve b/core/admin/mailu/internal/templates/default.sieve index d771ee99..5e995611 100644 --- a/core/admin/mailu/internal/templates/default.sieve +++ b/core/admin/mailu/internal/templates/default.sieve @@ -33,5 +33,5 @@ if exists "X-Virus" { } {% if user.reply_active %} -vacation :days 1 :subject "{{ user.reply_subject }}" "{{ user.reply_body }}"; +vacation :days 1 {% if user.displayed_name != "" %}:from "{{ user.displayed_name }} <{{ user.email }}>"{% endif %} :subject "{{ user.reply_subject }}" "{{ user.reply_body }}"; {% endif %} From aaa7ef5de3da26b8ee86f29e1f74025715e56be3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim=20M=C3=B6hlmann?= Date: Mon, 31 Dec 2018 03:13:47 +0200 Subject: [PATCH 28/41] Update demo server docs --- docs/demo.rst | 29 ++++++++++++++++++++--------- 1 file changed, 20 insertions(+), 9 deletions(-) diff --git a/docs/demo.rst b/docs/demo.rst index e2f6c4b0..9415e670 100644 --- a/docs/demo.rst +++ b/docs/demo.rst @@ -5,21 +5,32 @@ The demo server is for demonstration and test purposes only. Please be respectful and keep the demo server functional for others to be able to try it out. -The server is reset every day at 3am, french time. If you find the server is -unusable, you can still ask for someone to reset it manually on our Matrix -chat channel. Please do not open tickets everytime the server is down. Please -do not open tickets if the server is quite slow: it *is* slow because the -machine is a cheap leased server. +If you find the server is unusable, you can ask for someone to reset it manually on our Matrix +chat channel. Please do not open tickets every time the server is down. +Please do not open tickets if the server is quite slow: it *is* slow because the +services have only limited resources available. -Keep in mind that the demo server is also used for some automated tests and runs -the latest unstable version. If you find actual bugs when using the demo -server, please report these! +Keep in mind that the demo server runs the latest unstable (master) version. +If you find actual bugs when using the demo server, please report these! + +Functionality +------------- + +- The server is reset every day at 3am, UTC. +- You can send mail from any client to the server. + However, the stmp server is made incapable of relaying the e-mail to the destination server. + As such, the mail will never arrive. This is to prevent abuse of the server. +- The server is capable of receiving mail for any configured domains. +- The server exposes IMAP, POP3 and SMTP as usual for connection with mail clients such as Thunderbird. +- The containers have limited (throttled) CPU, this means it can respond slow during heavy operations. +- The containers have limited memory available and will be killed when exceeded. + This is to prevent people from doing nasty things to the server as a whole. Connecting to the server ------------------------ * Server name : ``test.mailu.io`` - * IP address : ``51.15.169.20`` + * IP address : ``173.249.45.89`` * Webmail : https://test.mailu.io/webmail/ * Admin UI : https://test.mailu.io/admin/ * Admin login : ``admin@test.mailu.io`` From 4c7cdeb43bfede6d296c9de6132771e647bf0214 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim=20M=C3=B6hlmann?= Date: Mon, 31 Dec 2018 04:13:25 +0200 Subject: [PATCH 29/41] FAQ: Difference between DOMAINS and HOSTNAMES - Closes #742 - Closes #747 --- docs/faq.rst | 47 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+) diff --git a/docs/faq.rst b/docs/faq.rst index 395b739c..7849d7c5 100644 --- a/docs/faq.rst +++ b/docs/faq.rst @@ -89,6 +89,51 @@ our ongoing `project management`_ discussion issue. Deployment related ------------------ +What is the difference between DOMAIN and HOSTNAMES? +```````````````````````````````````````````````````` + +Similair questions: + +- Changing domain doesn't work +- Do I need a certificate for ``DOMAIN``? + +``DOMAIN`` is the main mail domain. Aka, server identification for outgoing mail. DMARC reports point to ``POSTMASTER`` @ ``DOMAIN``. +These are really the only things it is used for. You don't need a cert for ``DOMAIN``, as it is a mail domain only and not used as host in any sense. +However, it is usual that ``DOMAIN`` gets setup as one of the many mail domains. None of the mail domains ever need a certificate. +TLS certificates work on host connection level only. + +``HOSTNAMES`` however, can be used to connect to the server. All host names supplied in this variable will need a certificate. When ``TLS_FLAVOR=letsencrypt`` is set, +a certificate is requested automatically for all those domains. + +So when you have something like this: + +.. code-block:: bash + + DOMAIN=example.com + POSTMASTER=me + HOSTNAMES=mail.example.com,mail.foo.com,bar.com + TLS_FLAVOR=letsencrypt + +- You'll end up with a DMARC address to ``me@example.com``. +- Server identifies itself as the SMTP server of ``@example.com`` when sending mail. Make sure your reverse DNS hostname is part of that domain! +- Your server will have certificates for the 3 hostnames. You will need to create ``A`` and ``AAAA`` records for those names, + pointing to the IP addresses of your server. +- The admin interface generates ``MX`` and ``SPF`` examples which point to the first entry of ``HOSTNAMES`` but these are only examples. + You can modify them to use any other ``HOSTNAMES`` entry. + +You're mail service will be reachable for IMAP, POP3, SMTP and Webmail at the addresses: + +- mail.example.com +- mail.foo.com +- bar.com + +.. note:: + + In this case ``example.com`` is not reachable as a host and will not have a certificate. + It can be used as a mail domain if MX is setup to point to one of the ``HOSTNAMES``. However, it is possible to include ``example.com`` in ``HOSTNAMES``. + +*Issue reference:* `742`_, `747`_. + How does Mailu scale up? ```````````````````````` @@ -154,6 +199,8 @@ correct syntax. The following file names will be taken as override configuration .. _`165`: https://github.com/Mailu/Mailu/issues/165 .. _`177`: https://github.com/Mailu/Mailu/issues/177 .. _`332`: https://github.com/Mailu/Mailu/issues/332 +.. _`742`: https://github.com/Mailu/Mailu/issues/742 +.. _`747`: https://github.com/Mailu/Mailu/issues/747 .. _`520`: https://github.com/Mailu/Mailu/issues/520 .. _`591`: https://github.com/Mailu/Mailu/issues/591 From dc238bb2b33f72db32c8bc6c2908e9ee79f9f9a0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim=20M=C3=B6hlmann?= Date: Mon, 31 Dec 2018 04:33:37 +0200 Subject: [PATCH 30/41] FAQ: Unbound DNS - Closes #554 --- docs/faq.rst | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/docs/faq.rst b/docs/faq.rst index 7849d7c5..8c1b0685 100644 --- a/docs/faq.rst +++ b/docs/faq.rst @@ -312,12 +312,30 @@ spam filter weight settings. *Issue reference:* `503`_. +rspamd: DNS query blocked on multi.uribl.com +```````````````````````````````````````````` + +This usually relates to the DNS server you are using. Most of the public servers block this query or there is a rate limit. +In order to solve this, you most probably are better off using a root DNS resolver, such as `unbound`_. This can be done in multiple ways: + +- Use the *Mailu/unbound* container. This is an optional include when generating the ``docker-compose.yml`` file with the setup utility. +- Setup unbound on the host and make sure the host's ``/etc/resolve.conf`` points to local host. + Docker will then forward all external DNS requests to the local server. +- Set up an external DNS server with root resolving capabilities. + +In any case, using a dedicated DNS server will improve the performance of your mail server. + +*Issue reference:* `554`_, `681`_. + .. _`troubleshooting tag`: https://github.com/Mailu/Mailu/issues?utf8=%E2%9C%93&q=label%3Afaq%2Ftroubleshooting .. _`85`: https://github.com/Mailu/Mailu/issues/85 .. _`116`: https://github.com/Mailu/Mailu/issues/116 .. _`171`: https://github.com/Mailu/Mailu/issues/171 .. _`426`: https://github.com/Mailu/Mailu/issues/426 .. _`503`: https://github.com/Mailu/Mailu/issues/503 +.. _`554`: https://github.com/Mailu/Mailu/issues/554 .. _`584`: https://github.com/Mailu/Mailu/issues/584 .. _`592`: https://github.com/Mailu/Mailu/issues/592 .. _`615`: https://github.com/Mailu/Mailu/issues/615 +.. _`681`: https://github.com/Mailu/Mailu/pull/681 +.. _`unbound`: https://nlnetlabs.nl/projects/unbound/about/ From df55b2e9d6f6865a7a59ec8ba338ef234852d9d2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim=20M=C3=B6hlmann?= Date: Mon, 31 Dec 2018 04:38:59 +0200 Subject: [PATCH 31/41] Reference and close #206 --- docs/faq.rst | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/docs/faq.rst b/docs/faq.rst index 8c1b0685..768bed83 100644 --- a/docs/faq.rst +++ b/docs/faq.rst @@ -191,6 +191,8 @@ correct syntax. The following file names will be taken as override configuration - `Dovecot`_ - ``dovecot.conf``; - `Rspamd`_ - All files in the ``rspamd`` sub-directory. +*Issue reference:* `206`_. + .. _`Postfix`: http://www.postfix.org/postconf.5.html .. _`Dovecot`: https://wiki.dovecot.org/ConfigFile .. _`Rspamd`: https://www.rspamd.com/doc/configuration/index.html @@ -325,12 +327,13 @@ In order to solve this, you most probably are better off using a root DNS resolv In any case, using a dedicated DNS server will improve the performance of your mail server. -*Issue reference:* `554`_, `681`_. +*Issue reference:* `206`_, `554`_, `681`_. .. _`troubleshooting tag`: https://github.com/Mailu/Mailu/issues?utf8=%E2%9C%93&q=label%3Afaq%2Ftroubleshooting .. _`85`: https://github.com/Mailu/Mailu/issues/85 .. _`116`: https://github.com/Mailu/Mailu/issues/116 .. _`171`: https://github.com/Mailu/Mailu/issues/171 +.. _`206`: https://github.com/Mailu/Mailu/issues/206 .. _`426`: https://github.com/Mailu/Mailu/issues/426 .. _`503`: https://github.com/Mailu/Mailu/issues/503 .. _`554`: https://github.com/Mailu/Mailu/issues/554 From 8dd30a698b56aa4a69c64d00e6155c0dfa8946f7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim=20M=C3=B6hlmann?= Date: Mon, 31 Dec 2018 04:51:12 +0200 Subject: [PATCH 32/41] FAQ: Rancher - Closes #125 --- docs/faq.rst | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/docs/faq.rst b/docs/faq.rst index 768bed83..6ee1871e 100644 --- a/docs/faq.rst +++ b/docs/faq.rst @@ -168,6 +168,16 @@ For **service** HA, please see: `How does Mailu scale up?`_ .. _`spam magnet`: https://blog.zensoftware.co.uk/2012/07/02/why-we-tend-to-recommend-not-having-a-secondary-mx-these-days/ +Does Mailu run on Rancher? +`````````````````````````` + +There is a rancher catalog for Mailu in the `Mailu/Rancher`_ repository. The user group for Rancher is small, +so we cannot promise any support on this when you're heading into trouble. See the repository README for more details. + +*Issue reference:* `125`_. + +.. _`Mailu/Rancher`: https://github.com/Mailu/Rancher + Can I run Mailu without host iptables? `````````````````````````````````````` @@ -198,6 +208,7 @@ correct syntax. The following file names will be taken as override configuration .. _`Rspamd`: https://www.rspamd.com/doc/configuration/index.html .. _`Docker swarm howto`: https://github.com/Mailu/Mailu/tree/master/docs/swarm/master +.. _`125`: https://github.com/Mailu/Mailu/issues/125 .. _`165`: https://github.com/Mailu/Mailu/issues/165 .. _`177`: https://github.com/Mailu/Mailu/issues/177 .. _`332`: https://github.com/Mailu/Mailu/issues/332 From 4c78785da32f3f7ea31d41b43815004be3e46ead Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim=20M=C3=B6hlmann?= Date: Mon, 31 Dec 2018 04:57:17 +0200 Subject: [PATCH 33/41] FAQ: DKIM and DMARC generation - Closes #102 --- docs/faq.rst | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/docs/faq.rst b/docs/faq.rst index 6ee1871e..ef4103c2 100644 --- a/docs/faq.rst +++ b/docs/faq.rst @@ -301,8 +301,18 @@ See also :ref:`external_certs`. *Issue reference:* `426`_, `615`_. +How do I activate DKIM and DMARC? +``````````````````````` +Go into the Domain Panel and choose the Domain you want to enable DKIM for. +Click the first icon on the left side (domain details). +Now click on the top right on the *"Regenerate Keys"* Button. +This will generate the DKIM and DMARC entries for you. + +*Issue reference:* `102`_. + Do you support Fail2Ban? ```````````````````````` + Fail2Ban is not included in Mailu. Fail2Ban needs to modify the host's IP tables in order to ban the addresses. We consider such a program should be run on the host system and not inside a container. The ``front`` container does use authentication rate limiting to slow @@ -342,6 +352,7 @@ In any case, using a dedicated DNS server will improve the performance of your m .. _`troubleshooting tag`: https://github.com/Mailu/Mailu/issues?utf8=%E2%9C%93&q=label%3Afaq%2Ftroubleshooting .. _`85`: https://github.com/Mailu/Mailu/issues/85 +.. _`102`: https://github.com/Mailu/Mailu/issues/102 .. _`116`: https://github.com/Mailu/Mailu/issues/116 .. _`171`: https://github.com/Mailu/Mailu/issues/171 .. _`206`: https://github.com/Mailu/Mailu/issues/206 From f91b80503e132c1b34ddf3759e08f501204a3bb0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim=20M=C3=B6hlmann?= Date: Mon, 31 Dec 2018 05:11:56 +0200 Subject: [PATCH 34/41] FAQ: Older ciphers - Closes #698 --- docs/faq.rst | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/docs/faq.rst b/docs/faq.rst index ef4103c2..545e0427 100644 --- a/docs/faq.rst +++ b/docs/faq.rst @@ -350,12 +350,29 @@ In any case, using a dedicated DNS server will improve the performance of your m *Issue reference:* `206`_, `554`_, `681`_. +Is there a way to support more (older) ciphers? +``````````````````````````````````````````````` + +See `How can I override settings?`_ . +You will need to add the protocols you wish to support in an override for the ``front`` container (Nginx). + +.. code-block:: bash + + ssl_protocols TLSv1 TLSv1.1 TLSv1.2; + ssl_ciphers ; + +We **strongly** advice against downgrading the TLS version and ciphers! + +*Issue reference:* `363`_, `698`_. + + .. _`troubleshooting tag`: https://github.com/Mailu/Mailu/issues?utf8=%E2%9C%93&q=label%3Afaq%2Ftroubleshooting .. _`85`: https://github.com/Mailu/Mailu/issues/85 .. _`102`: https://github.com/Mailu/Mailu/issues/102 .. _`116`: https://github.com/Mailu/Mailu/issues/116 .. _`171`: https://github.com/Mailu/Mailu/issues/171 .. _`206`: https://github.com/Mailu/Mailu/issues/206 +.. _`363`: https://github.com/Mailu/Mailu/issues/363 .. _`426`: https://github.com/Mailu/Mailu/issues/426 .. _`503`: https://github.com/Mailu/Mailu/issues/503 .. _`554`: https://github.com/Mailu/Mailu/issues/554 @@ -363,4 +380,5 @@ In any case, using a dedicated DNS server will improve the performance of your m .. _`592`: https://github.com/Mailu/Mailu/issues/592 .. _`615`: https://github.com/Mailu/Mailu/issues/615 .. _`681`: https://github.com/Mailu/Mailu/pull/681 +.. _`698`: https://github.com/Mailu/Mailu/issues/698 .. _`unbound`: https://nlnetlabs.nl/projects/unbound/about/ From 16c47faf35e393925f3e3320b16a255dfe3f25d5 Mon Sep 17 00:00:00 2001 From: Daniel Huber Date: Mon, 31 Dec 2018 12:39:35 +0100 Subject: [PATCH 35/41] Fix default docker prefix value of traefik certdumper docker-compose logs a warning if a environment variable is not set and has no default value. This adds a default string as the default for traefik certdumper which was added in 7c7b52d9. --- tests/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/build.yml b/tests/build.yml index 3436d25a..e06327cd 100644 --- a/tests/build.yml +++ b/tests/build.yml @@ -31,7 +31,7 @@ services: build: ../optional/radicale traefik-certdumper: - image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX}traefik-certdumper:${MAILU_VERSION:-local} + image: ${DOCKER_ORG:-mailu}/${DOCKER_PREFIX:-}traefik-certdumper:${MAILU_VERSION:-local} build: ../optional/traefik-certdumper admin: From 4a072992dbf0c2bac96b01d8ffbaca3c6785317d Mon Sep 17 00:00:00 2001 From: Dennis Neufeld Date: Tue, 1 Jan 2019 18:48:09 +0100 Subject: [PATCH 36/41] Fix typo in demo.rst --- docs/demo.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/demo.rst b/docs/demo.rst index 9415e670..fb66f2ff 100644 --- a/docs/demo.rst +++ b/docs/demo.rst @@ -18,7 +18,7 @@ Functionality - The server is reset every day at 3am, UTC. - You can send mail from any client to the server. - However, the stmp server is made incapable of relaying the e-mail to the destination server. + However, the SMTP server is made incapable of relaying the e-mail to the destination server. As such, the mail will never arrive. This is to prevent abuse of the server. - The server is capable of receiving mail for any configured domains. - The server exposes IMAP, POP3 and SMTP as usual for connection with mail clients such as Thunderbird. From f2e3d755a620dded0e0fb5980810b09a3a458a3c Mon Sep 17 00:00:00 2001 From: hoellen Date: Wed, 2 Jan 2019 10:59:19 +0100 Subject: [PATCH 37/41] add nginx conf override to faq --- docs/faq.rst | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/faq.rst b/docs/faq.rst index 395b739c..4d134edd 100644 --- a/docs/faq.rst +++ b/docs/faq.rst @@ -138,17 +138,19 @@ For that reason we do **not** support deployment on Docker hosts without iptable How can I override settings? ```````````````````````````` -Postfix, dovecot and Rspamd support overriding configuration files. Override files belong in +Postfix, Dovecot, Nginx and Rspamd support overriding configuration files. Override files belong in ``$ROOT/overrides``. Please refer to the official documentation of those programs for the correct syntax. The following file names will be taken as override configuration: - `Postfix`_ - ``postfix.cf``; - `Dovecot`_ - ``dovecot.conf``; +- `Nginx`_ - All ``*.conf`` files in the ``nginx`` sub-directory. - `Rspamd`_ - All files in the ``rspamd`` sub-directory. .. _`Postfix`: http://www.postfix.org/postconf.5.html .. _`Dovecot`: https://wiki.dovecot.org/ConfigFile -.. _`Rspamd`: https://www.rspamd.com/doc/configuration/index.html +.. _`NGINX`: https://nginx.org/en/docs/ +.. _`Rspamd`: https://www.rspamd.com/doc/configuration/index.html .. _`Docker swarm howto`: https://github.com/Mailu/Mailu/tree/master/docs/swarm/master .. _`165`: https://github.com/Mailu/Mailu/issues/165 From f617e82c069ed5e4b5b959ff693ea6fcce238a07 Mon Sep 17 00:00:00 2001 From: hoellen Date: Wed, 2 Jan 2019 14:08:03 +0100 Subject: [PATCH 38/41] fix broken webmail and logo url in admin --- core/admin/mailu/ui/templates/base.html | 2 +- core/admin/mailu/ui/templates/sidebar.html | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/core/admin/mailu/ui/templates/base.html b/core/admin/mailu/ui/templates/base.html index 08488560..73fa7aa7 100644 --- a/core/admin/mailu/ui/templates/base.html +++ b/core/admin/mailu/ui/templates/base.html @@ -28,7 +28,7 @@ class="hold-transition skin-blue sidebar-mini"
{% block navbar %}
-
diff --git a/core/admin/mailu/ui/templates/sidebar.html b/core/admin/mailu/ui/templates/sidebar.html index c3a2ced6..3d945380 100644 --- a/core/admin/mailu/ui/templates/sidebar.html +++ b/core/admin/mailu/ui/templates/sidebar.html @@ -69,7 +69,7 @@
  • {% trans %}Go to{% endtrans %}
  • {% if config["WEBMAIL"] != "none" %}
  • - + {% trans %}Webmail{% endtrans %}
  • From 8c8e06de4864c4a044fc79f25494870ff4023ca3 Mon Sep 17 00:00:00 2001 From: hoellen Date: Wed, 2 Jan 2019 14:19:55 +0100 Subject: [PATCH 39/41] add #792 to changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index f3bcce93..93b51220 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -107,6 +107,7 @@ v1.6.0 - unreleased - Bug: Hostname resolving in start.py should retry on failure [docker swarm] ([#555](https://github.com/Mailu/Mailu/issues/555)) - Bug: Error when trying to log in with an account without domain ([#585](https://github.com/Mailu/Mailu/issues/585)) - Bug: Fix rainloop permissions ([#637](https://github.com/Mailu/Mailu/issues/637)) +- Bug: Fix broken webmail and logo url in admin ([#792](https://github.com/Mailu/Mailu/issues/792)) v1.5.1 - 2017-11-21 ------------------- From 47234786ea9e3c56eb97ed37aaaf7146b92fb4df Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim=20M=C3=B6hlmann?= Date: Wed, 2 Jan 2019 19:12:46 +0200 Subject: [PATCH 40/41] Disable mergify strict mode --- .mergify.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.mergify.yml b/.mergify.yml index a950b0ca..927bfc3e 100644 --- a/.mergify.yml +++ b/.mergify.yml @@ -7,7 +7,6 @@ pull_request_rules: actions: merge: method: merge - strict: true dismiss_reviews: approved: true @@ -20,6 +19,5 @@ pull_request_rules: actions: merge: method: merge - strict: true dismiss_reviews: approved: true From cd85b4497269596341eb707ae5e3a1dff2e78a58 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim=20M=C3=B6hlmann?= Date: Wed, 2 Jan 2019 19:15:56 +0200 Subject: [PATCH 41/41] Fix typo --- docs/faq.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/faq.rst b/docs/faq.rst index 545e0427..8bd82d95 100644 --- a/docs/faq.rst +++ b/docs/faq.rst @@ -92,7 +92,7 @@ Deployment related What is the difference between DOMAIN and HOSTNAMES? ```````````````````````````````````````````````````` -Similair questions: +Similar questions: - Changing domain doesn't work - Do I need a certificate for ``DOMAIN``?