From cfeaa189f96d357d82928658c86001cc3923236a Mon Sep 17 00:00:00 2001
From: kaiyou <pierre@jaury.eu>
Date: Thu, 27 Sep 2018 08:00:31 +0200
Subject: [PATCH] Use proper 404 return codes for missing objects

---
 core/admin/mailu/internal/views.py | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/core/admin/mailu/internal/views.py b/core/admin/mailu/internal/views.py
index 78d1528a..83cd4718 100644
--- a/core/admin/mailu/internal/views.py
+++ b/core/admin/mailu/internal/views.py
@@ -95,7 +95,7 @@ def postfix_transport(email):
 
 @internal.route("/dovecot/passdb/<user_email>")
 def dovecot_passdb_dict(user_email):
-    user = models.User.query.get(user_email) or flask.abort(403)
+    user = models.User.query.get(user_email) or flask.abort(404)
     return flask.jsonify({
         "password": user.password,
     })
@@ -103,7 +103,7 @@ def dovecot_passdb_dict(user_email):
 
 @internal.route("/dovecot/userdb/<user_email>")
 def dovecot_userdb_dict(user_email):
-    user = models.User.query.get(user_email) or flask.abort(403)
+    user = models.User.query.get(user_email) or flask.abort(404)
     return flask.jsonify({
         "quota_rule": "*:bytes={}".format(user.quota_bytes)
     })
@@ -111,9 +111,18 @@ def dovecot_userdb_dict(user_email):
 
 @internal.route("/dovecot/quota/<ns>/<user_email>", methods=["POST"])
 def dovecot_quota(ns, user_email):
-    user = models.User.query.get(user_email) or flask.abort(403)
+    user = models.User.query.get(user_email) or flask.abort(404)
     if ns == "storage":
         user.quota_bytes_used = flask.request.get_json()
         db.session.commit()
     return flask.jsonify(None)
 
+
+@internal.route("/dovecot/sieve/name/<script>/<user_email>")
+def dovecot_sieve(script, user_email):
+    user = models.User.query.get(user_email) or flask.abort(404)
+    if script == "default":
+        pass
+    else:
+        flask.abort(404)
+